Skip to content

Commit 47d6b5e

Browse files
committed
Replace deprecated django.conf.urls.url() with path() and re_path()
django.urls.path() and re_path() have been available since Django 2.0. django.conf.urls.url() is deprecated in Django 3.1. When testing against Django 3.1, fixes warning of the form: RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path().
1 parent e2b00ad commit 47d6b5e

File tree

6 files changed

+31
-36
lines changed

6 files changed

+31
-36
lines changed

debug_toolbar/panels/sql/panel.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
from copy import copy
44
from pprint import saferepr
55

6-
from django.conf.urls import url
76
from django.db import connections
7+
from django.urls import path
88
from django.utils.translation import gettext_lazy as _, ngettext_lazy as __
99

1010
from debug_toolbar.panels import Panel
@@ -128,9 +128,9 @@ def title(self):
128128
@classmethod
129129
def get_urls(cls):
130130
return [
131-
url(r"^sql_select/$", views.sql_select, name="sql_select"),
132-
url(r"^sql_explain/$", views.sql_explain, name="sql_explain"),
133-
url(r"^sql_profile/$", views.sql_profile, name="sql_profile"),
131+
path("sql_select/", views.sql_select, name="sql_select"),
132+
path("sql_explain/", views.sql_explain, name="sql_explain"),
133+
path("sql_profile/", views.sql_profile, name="sql_profile"),
134134
]
135135

136136
def enable_instrumentation(self):

debug_toolbar/panels/templates/panel.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
from pprint import pformat, saferepr
55

66
from django import http
7-
from django.conf.urls import url
87
from django.core import signing
98
from django.db.models.query import QuerySet, RawQuerySet
109
from django.template import RequestContext, Template
1110
from django.test.signals import template_rendered
1211
from django.test.utils import instrumented_test_render
12+
from django.urls import path
1313
from django.utils.translation import gettext_lazy as _
1414

1515
from debug_toolbar.panels import Panel
@@ -161,9 +161,7 @@ def nav_subtitle(self):
161161

162162
@classmethod
163163
def get_urls(cls):
164-
return [
165-
url(r"^template_source/$", views.template_source, name="template_source")
166-
]
164+
return [path("template_source/", views.template_source, name="template_source")]
167165

168166
def enable_instrumentation(self):
169167
template_rendered.connect(self._store_template_info)

debug_toolbar/toolbar.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
from collections import OrderedDict
77

88
from django.apps import apps
9-
from django.conf.urls import url
109
from django.core.exceptions import ImproperlyConfigured
1110
from django.template import TemplateSyntaxError
1211
from django.template.loader import render_to_string
12+
from django.urls import path
1313
from django.utils.module_loading import import_string
1414

1515
from debug_toolbar import settings as dt_settings
@@ -128,7 +128,7 @@ def get_urls(cls):
128128
# Load URLs in a temporary variable for thread safety.
129129
# Global URLs
130130
urlpatterns = [
131-
url(r"^render_panel/$", views.render_panel, name="render_panel")
131+
path("render_panel/", views.render_panel, name="render_panel")
132132
]
133133
# Per-panel URLs
134134
for panel_class in cls.get_panel_classes():

docs/installation.rst

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,12 @@ Setting up URLconf
4646
Add the Debug Toolbar's URLs to your project's URLconf as follows::
4747

4848
from django.conf import settings
49-
from django.conf.urls import include, url # For django versions before 2.0
50-
from django.urls import include, path # For django versions from 2.0 and up
49+
from django.urls import include, path
5150

5251
if settings.DEBUG:
5352
import debug_toolbar
5453
urlpatterns = [
5554
path('__debug__/', include(debug_toolbar.urls)),
56-
57-
# For django versions before 2.0:
58-
# url(r'^__debug__/', include(debug_toolbar.urls)),
59-
6055
] + urlpatterns
6156

6257
This example uses the ``__debug__`` prefix, but you can use any prefix that

example/urls.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
from django.conf import settings
2-
from django.conf.urls import include, url
32
from django.contrib import admin
3+
from django.urls import include, path
44
from django.views.generic import TemplateView
55

66
urlpatterns = [
7-
url(r"^$", TemplateView.as_view(template_name="index.html")),
8-
url(r"^jquery/$", TemplateView.as_view(template_name="jquery/index.html")),
9-
url(r"^mootools/$", TemplateView.as_view(template_name="mootools/index.html")),
10-
url(r"^prototype/$", TemplateView.as_view(template_name="prototype/index.html")),
11-
url(r"^admin/", admin.site.urls),
7+
path("", TemplateView.as_view(template_name="index.html")),
8+
path("jquery/", TemplateView.as_view(template_name="jquery/index.html")),
9+
path("mootools/", TemplateView.as_view(template_name="mootools/index.html")),
10+
path("prototype/", TemplateView.as_view(template_name="prototype/index.html")),
11+
path("admin/", admin.site.urls),
1212
]
1313

1414
if settings.DEBUG:
1515
import debug_toolbar
1616

17-
urlpatterns += [url(r"^__debug__/", include(debug_toolbar.urls))]
17+
urlpatterns += [path("__debug__/", include(debug_toolbar.urls))]

tests/urls.py

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,23 @@
1-
from django.conf.urls import include, url
1+
from django.urls import include, path, re_path
22

33
import debug_toolbar
44

55
from . import views
66
from .models import NonAsciiRepr
77

88
urlpatterns = [
9-
url(r"^resolving1/(.+)/(.+)/$", views.resolving_view, name="positional-resolving"),
10-
url(r"^resolving2/(?P<arg1>.+)/(?P<arg2>.+)/$", views.resolving_view),
11-
url(r"^resolving3/(.+)/$", views.resolving_view, {"arg2": "default"}),
12-
url(r"^regular/(?P<title>.*)/$", views.regular_view),
13-
url(r"^template_response/(?P<title>.*)/$", views.template_response_view),
14-
url(r"^regular_jinja/(?P<title>.*)/$", views.regular_jinjia_view),
15-
url(r"^non_ascii_request/$", views.regular_view, {"title": NonAsciiRepr()}),
16-
url(r"^new_user/$", views.new_user),
17-
url(r"^execute_sql/$", views.execute_sql),
18-
url(r"^cached_view/$", views.cached_view),
19-
url(r"^redirect/$", views.redirect_view),
20-
url(r"^__debug__/", include(debug_toolbar.urls)),
9+
re_path(
10+
r"^resolving1/(.+)/(.+)/$", views.resolving_view, name="positional-resolving"
11+
),
12+
re_path(r"^resolving2/(?P<arg1>.+)/(?P<arg2>.+)/$", views.resolving_view),
13+
re_path(r"^resolving3/(.+)/$", views.resolving_view, {"arg2": "default"}),
14+
re_path(r"^regular/(?P<title>.*)/$", views.regular_view),
15+
re_path(r"^template_response/(?P<title>.*)/$", views.template_response_view),
16+
re_path(r"^regular_jinja/(?P<title>.*)/$", views.regular_jinjia_view),
17+
path("non_ascii_request/", views.regular_view, {"title": NonAsciiRepr()}),
18+
path("new_user/", views.new_user),
19+
path("execute_sql/", views.execute_sql),
20+
path("cached_view/", views.cached_view),
21+
path("redirect/", views.redirect_view),
22+
path("__debug__/", include(debug_toolbar.urls)),
2123
]

0 commit comments

Comments
 (0)