Support DEFAULT_CHARSET != 'utf-8'. Fix #15.

aaugustin · aaugustin · commit 4d829c450327 · 2013-10-17T21:30:15.000+02:00
diff --git a/debug_toolbar/middleware.py b/debug_toolbar/middleware.py
@@ -135,7 +135,7 @@ def process_response(self, request, response):
             for panel in toolbar.panels:
                 panel.process_response(request, response)
             response.content = replace_insensitive(
-                force_text(response.content),
+                force_text(response.content, encoding=settings.DEFAULT_CHARSET),
                 self.tag,
                 force_text(toolbar.render_toolbar() + self.tag))
             if response.get('Content-Length', None):
diff --git a/tests/tests.py b/tests/tests.py
@@ -1,3 +1,5 @@
+# coding: utf-8
+
 from __future__ import unicode_literals
 
 import threading
@@ -161,6 +163,19 @@ def test_url_resolving_bad(self):
         self.assertEqual(stats['view_kwargs'], 'None')
         self.assertEqual(stats['view_func'], '<no view>')
 
+    def test_non_utf8_charset(self):
+        with self.settings(DEBUG=True,
+                           DEFAULT_CHARSET='iso-8859-1',
+                           INTERNAL_IPS=['127.0.0.1']):
+
+            response = self.client.get('/regular/ASCII/')
+            self.assertContains(response, 'ASCII')      # template
+            self.assertContains(response, 'djDebug')    # toolbar
+
+            response = self.client.get('/regular/LÀTÍN/')
+            self.assertContains(response, 'LÀTÍN')      # template
+            self.assertContains(response, 'djDebug')    # toolbar
+
 
 class DebugToolbarNameFromObjectTest(BaseTestCase):
     def test_func(self):
diff --git a/tests/urls.py b/tests/urls.py
@@ -12,10 +12,10 @@
 
 admin.autodiscover()
 
-urlpatterns = patterns('',
-    # This pattern should be last to ensure tests still work
-    url(r'^resolving1/(.+)/(.+)/$', 'tests.views.resolving_view', name='positional-resolving'),
-    url(r'^resolving2/(?P<arg1>.+)/(?P<arg2>.+)/$', 'tests.views.resolving_view'),
-    url(r'^resolving3/(.+)/$', 'tests.views.resolving_view', { 'arg2' : 'default' }),
-    url(r'^execute_sql/$', 'tests.views.execute_sql'),
+urlpatterns = patterns('tests.views',
+    url(r'^resolving1/(.+)/(.+)/$', 'resolving_view', name='positional-resolving'),
+    url(r'^resolving2/(?P<arg1>.+)/(?P<arg2>.+)/$', 'resolving_view'),
+    url(r'^resolving3/(.+)/$', 'resolving_view', { 'arg2' : 'default' }),
+    url(r'^regular/(?P<title>.*)/$', 'regular_view'),
+    url(r'^execute_sql/$', 'execute_sql'),
 )
diff --git a/tests/views.py b/tests/views.py
@@ -3,12 +3,17 @@
 from django.contrib.auth.models import User
 from django.http import HttpResponse
 
+
 def execute_sql(request):
     list(User.objects.all())
-
     return HttpResponse()
 
+
+def regular_view(request, title='Test'):
+    content = '<html><head><title>%s</title><body></body></html>' % title
+    return HttpResponse(content)
+
+
 def resolving_view(request, arg1, arg2):
     # see test_url_resolving in tests.py
     return HttpResponse()
-
