Merge pull request #1273 from jdufresne/lower

matthiask · web-flow · commit 663fc278969a · 2020-05-18T09:14:16.000+02:00
Remove unnecessary .toLowerCase() operation
diff --git a/debug_toolbar/static/debug_toolbar/js/toolbar.js b/debug_toolbar/static/debug_toolbar/js/toolbar.js
@@ -108,10 +108,9 @@
             $$.on(djDebug, 'click', '.remoteCall', function(event) {
                 event.preventDefault();
 
-                var name = this.tagName.toLowerCase();
                 var ajax_data = {};
 
-                if (name == 'button') {
+                if (this.tagName == 'BUTTON') {
                     var form = this.closest('form');
                     ajax_data.url = this.getAttribute('formaction');
 
@@ -121,7 +120,7 @@
                     }
                 }
 
-                if (name == 'a') {
+                if (this.tagName == 'A') {
                     ajax_data.url = this.getAttribute('href');
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -108,10 +108,9 @@`
`108`	`108`	`$$.on(djDebug, 'click', '.remoteCall', function(event) {`
`109`	`109`	`event.preventDefault();`
`110`	`110`
`111`		`- var name = this.tagName.toLowerCase();`
`112`	`111`	`var ajax_data = {};`
`113`	`112`
`114`		`- if (name == 'button') {`
	`113`	`+ if (this.tagName == 'BUTTON') {`
`115`	`114`	`var form = this.closest('form');`
`116`	`115`	`ajax_data.url = this.getAttribute('formaction');`
`117`	`116`
`@@ -121,7 +120,7 @@`
`121`	`120`	`}`
`122`	`121`	`}`
`123`	`122`
`124`		`- if (name == 'a') {`
	`123`	`+ if (this.tagName == 'A') {`
`125`	`124`	`ajax_data.url = this.getAttribute('href');`
`126`	`125`	`}`
`127`	`126`