Skip to content

Commit 7d29b40

Browse files
blueyedtim-schilling
authored andcommitted
logging: do not change the root logger's level
Fixes #572
1 parent 6270a9e commit 7d29b40

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

debug_toolbar/panels/logging.py

-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ def emit(self, record):
5050

5151
collector = LogCollector()
5252
logging_handler = ThreadTrackingHandler(collector)
53-
logging.root.setLevel(logging.NOTSET)
5453
logging.root.addHandler(logging_handler)
5554

5655

tests/panels/test_logging.py

+4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@ def setUp(self):
1616
self.logger = logging.getLogger(__name__)
1717
collector.clear_collection()
1818

19+
# Assume the root logger has been configured with level=DEBUG.
20+
# Previously DDT forcefully set this itself to 0 (NOTSET).
21+
logging.root.setLevel(logging.DEBUG)
22+
1923
def test_happy_case(self):
2024
self.logger.info('Nothing to see here, move along!')
2125

0 commit comments

Comments
 (0)