Skip to content

Commit 9fc416e

Browse files
committed
Merge remote-tracking branch 'jdufresne/redundant-setting'
* jdufresne/redundant-setting: Remove redundant @override_settings(DEBUG=True) calls
2 parents 629c1c9 + d6be212 commit 9fc416e

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

tests/panels/test_history.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ def test_urls(self):
6363
)
6464

6565

66+
@override_settings(DEBUG=True)
6667
class HistoryViewsTestCase(IntegrationTestCase):
67-
@override_settings(DEBUG=True)
6868
def test_history_panel_integration_content(self):
6969
"""Verify the history panel's content renders properly.."""
7070
self.assertEqual(len(DebugToolbar._store), 0)
@@ -78,7 +78,6 @@ def test_history_panel_integration_content(self):
7878
content = toolbar.get_panel_by_id("HistoryPanel").content
7979
self.assertIn("bar", content)
8080

81-
@override_settings(DEBUG=True)
8281
def test_history_sidebar_invalid(self):
8382
response = self.client.get(reverse("djdt:history_sidebar"))
8483
self.assertEqual(response.status_code, 400)
@@ -90,7 +89,6 @@ def test_history_sidebar_invalid(self):
9089
response = self.client.get(reverse("djdt:history_sidebar"), data=data)
9190
self.assertEqual(response.status_code, 400)
9291

93-
@override_settings(DEBUG=True)
9492
@patch("debug_toolbar.panels.history.views.DebugToolbar.fetch")
9593
def test_history_sidebar_hash(self, fetch):
9694
"""Validate the hashing mechanism."""
@@ -103,7 +101,6 @@ def test_history_sidebar_hash(self, fetch):
103101
self.assertEqual(response.status_code, 200)
104102
self.assertEqual(response.json(), {})
105103

106-
@override_settings(DEBUG=True)
107104
def test_history_sidebar(self):
108105
"""Validate the history sidebar view."""
109106
self.client.get("/json_view/")
@@ -132,7 +129,6 @@ def test_history_sidebar(self):
132129
},
133130
)
134131

135-
@override_settings(DEBUG=True)
136132
def test_history_refresh_invalid(self):
137133
response = self.client.get(reverse("djdt:history_refresh"))
138134
self.assertEqual(response.status_code, 400)
@@ -144,7 +140,6 @@ def test_history_refresh_invalid(self):
144140
response = self.client.get(reverse("djdt:history_refresh"), data=data)
145141
self.assertEqual(response.status_code, 400)
146142

147-
@override_settings(DEBUG=True)
148143
def test_history_refresh(self):
149144
"""Verify refresh history response has request variables."""
150145
data = {"foo": "bar"}

tests/test_integration.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,6 @@ def test_expired_store(self):
403403
self.assertIn("Data for this panel isn't available anymore.", error.text)
404404

405405
@override_settings(
406-
DEBUG=True,
407406
TEMPLATES=[
408407
{
409408
"BACKEND": "django.template.backends.django.DjangoTemplates",

0 commit comments

Comments
 (0)