Address new ruff 0.16 and biome 2.5.5 warnings

Author: codingjoe

biome.json

@@ -1,5 +1,5 @@
 {
-    "$schema": "https://biomejs.dev/schemas/2.5.2/schema.json",
+    "$schema": "https://biomejs.dev/schemas/2.5.5/schema.json",
     "formatter": {
         "enabled": true,
         "useEditorconfig": true

debug_toolbar/apps.py

@@ -177,8 +177,7 @@ def check_panel_configs(app_configs, **kwargs):
 
     errors = []
     for panel_class in DebugToolbar.get_panel_classes():
-        for check_message in panel_class.run_checks():
-            errors.append(check_message)
+        errors.extend(panel_class.run_checks())
     return errors
 
 

debug_toolbar/middleware.py

@@ -34,11 +34,7 @@ def show_toolbar(request: HttpRequest) -> bool:
         return False
 
     # Test: settings
-    if request.META.get("REMOTE_ADDR") in settings.INTERNAL_IPS:
-        return True
-
-    # No test passed
-    return False
+    return request.META.get("REMOTE_ADDR") in settings.INTERNAL_IPS
 
 
 def show_toolbar_with_docker(request: HttpRequest) -> bool:

debug_toolbar/panels/history/__init__.py

@@ -1,3 +1,3 @@
 from debug_toolbar.panels.history.panel import HistoryPanel
 
-__all__: list[str] = [HistoryPanel.panel_id]
+__all__: list[str] = ["HistoryPanel"]

debug_toolbar/panels/profiling.py

@@ -87,7 +87,7 @@ def func_std_string(self):  # match what old profile produced
             )
 
     def subfuncs(self):
-        h, s, v = self.hsv
+        h, s, _v = self.hsv
         count = len(self.statobj.all_callees[self.func])
         for i, (func, stats) in enumerate(self.statobj.all_callees[self.func].items()):
             h1 = h + ((i + 1) / count) / (self.depth + 1)
@@ -109,25 +109,25 @@ def tottime(self):
         return self.stats[2]
 
     def cumtime(self):
-        cc, nc, tt, ct = self.stats
-        return self.stats[3]
+        _cc, _nc, _tt, ct = self.stats
+        return ct
 
     def tottime_per_call(self):
-        cc, nc, tt, ct = self.stats
+        _cc, nc, tt, _ct = self.stats
 
-        if nc == 0:
+        try:
+            return tt / nc
+        except ZeroDivisionError:
             return 0
 
-        return tt / nc
-
     def cumtime_per_call(self):
-        cc, nc, tt, ct = self.stats
+        cc, _nc, _tt, ct = self.stats
 
-        if cc == 0:
+        try:
+            return ct / cc
+        except ZeroDivisionError:
             return 0
 
-        return ct / cc
-
     def indent(self):
         return 16 * self.depth
 

debug_toolbar/panels/redirects.py

@@ -22,10 +22,11 @@ def _process_response(self, response):
         """
         Common response processing logic.
         """
-        if 300 <= response.status_code < 400:
-            if redirect_to := response.get("Location"):
-                response = self.get_interception_response(response, redirect_to)
-                response.render()
+        if 300 <= response.status_code < 400 and (
+            redirect_to := response.get("Location")
+        ):
+            response = self.get_interception_response(response, redirect_to)
+            response.render()
         return response
 
     async def aprocess_request(self, request, response_coroutine):

debug_toolbar/panels/settings.py

@@ -11,7 +11,7 @@
 def safe_pformat(obj):
     try:
         return pformat(obj)
-    except Exception as e:
+    except ValueError as e:
         return f"<unformattable {type(obj).__name__}: {e!r}>"
 
 

debug_toolbar/panels/sql/__init__.py

@@ -1,3 +1,3 @@
 from debug_toolbar.panels.sql.panel import SQLPanel
 
-__all__ = [SQLPanel.panel_id]
+__all__ = ["SQLPanel"]

debug_toolbar/panels/sql/views.py

@@ -1,3 +1,4 @@
+from django.db import DatabaseError
 from django.http import HttpResponseBadRequest, JsonResponse
 from django.template.loader import render_to_string
 from django.views.decorators.csrf import csrf_exempt
@@ -88,7 +89,7 @@ def sql_profile(request):
         result_error = None
         try:
             result, headers = form.profile()
-        except Exception:
+        except DatabaseError:
             result_error = (
                 "Profiling is either not available or not supported by your database."
             )

debug_toolbar/panels/staticfiles.py

@@ -57,9 +57,9 @@ def __init__(self, *args, **kwargs):
 
     @classmethod
     def ready(cls):
-        cls = storage.staticfiles_storage.__class__
-        if URLMixin not in cls.mro():
-            cls.__bases__ = (URLMixin, *cls.__bases__)
+        klass = storage.staticfiles_storage.__class__
+        if URLMixin not in klass.mro():
+            klass.__bases__ = (URLMixin, *klass.__bases__)
 
     def _store_static_files_signal_handler(self, sender, staticfile, **kwargs):
         # Only record the static file if the request_id matches the one
@@ -114,7 +114,7 @@ def get_staticfiles_finders(self):
                     else:
                         prefixed_path = path
                     finder_cls = finder.__class__
-                    finder_path = ".".join([finder_cls.__module__, finder_cls.__name__])
+                    finder_path = f"{finder_cls.__module__}.{finder_cls.__name__}"
                     real_path = finder_storage.path(path)
                     payload = (prefixed_path, real_path)
                     finders_mapping.setdefault(finder_path, []).append(payload)