Skip to content

Commit ad31833

Browse files
committed
Move two tests specific to the request vars panel in their module.
1 parent b1d8b11 commit ad31833

File tree

5 files changed

+37
-20
lines changed

5 files changed

+37
-20
lines changed

tests/panels/test_request_vars.py

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
# coding: utf-8
2+
3+
from __future__ import unicode_literals
4+
5+
from django.utils import six
6+
7+
from debug_toolbar.panels.request_vars import RequestVarsDebugPanel
8+
9+
from ..base import BaseTestCase
10+
from ..models import NonAsciiRepr
11+
12+
13+
class RequestVarsDebugPanelTestCase(BaseTestCase):
14+
15+
def setUp(self):
16+
super(RequestVarsDebugPanelTestCase, self).setUp()
17+
self.panel = self.toolbar.get_panel(RequestVarsDebugPanel)
18+
19+
def test_non_ascii_session(self):
20+
self.request.session = {'où': 'où'}
21+
if not six.PY3:
22+
self.request.session['là'.encode('utf-8')] = 'là'.encode('utf-8')
23+
self.panel.process_request(self.request)
24+
self.panel.process_response(self.request, self.response)
25+
content = self.panel.content()
26+
if six.PY3:
27+
self.assertIn('où', content)
28+
else:
29+
self.assertIn('o\\xf9', content)
30+
self.assertIn('l\\xc3\\xa0', content)
31+
32+
def test_object_with_non_ascii_repr_in_request_vars(self):
33+
self.request.path = '/non_ascii_request/'
34+
self.panel.process_request(self.request)
35+
self.panel.process_response(self.request, self.response)
36+
self.assertIn('nôt åscíì', self.panel.content())

tests/test_integration.py

-12
Original file line numberDiff line numberDiff line change
@@ -137,18 +137,6 @@ def test_non_utf8_charset(self):
137137
self.assertContains(response, 'LÀTÍN') # template
138138
self.assertContains(response, 'djDebug') # toolbar
139139

140-
def test_non_ascii_session(self):
141-
response = self.client.get('/set_session/')
142-
if six.PY3:
143-
self.assertContains(response, 'où')
144-
else:
145-
self.assertContains(response, 'o\\xf9')
146-
self.assertContains(response, 'l\\xc3\\xa0')
147-
148-
def test_object_with_non_ascii_repr_in_request_vars(self):
149-
response = self.client.get('/non_ascii_request/')
150-
self.assertContains(response, 'nôt åscíì')
151-
152140
def test_xml_validation(self):
153141
response = self.client.get('/regular/XML/')
154142
ET.fromstring(response.content) # shouldn't raise ParseError

tests/tests.py

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from .commands.test_debugsqlshell import * # noqa
55
from .panels.test_logger import * # noqa
66
from .panels.test_profiling import * # noqa
7+
from .panels.test_request_vars import * # noqa
78
from .panels.test_sql import * # noqa
89
from .panels.test_template import * # noqa
910
from .test_integration import * # noqa

tests/urls.py

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
admin.autodiscover()
1212

1313
urlpatterns = patterns('tests.views', # noqa
14-
url(r'^set_session/$', 'set_session'),
1514
url(r'^resolving1/(.+)/(.+)/$', 'resolving_view', name='positional-resolving'),
1615
url(r'^resolving2/(?P<arg1>.+)/(?P<arg2>.+)/$', 'resolving_view'),
1716
url(r'^resolving3/(.+)/$', 'resolving_view', {'arg2': 'default'}),

tests/views.py

-7
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,3 @@ def new_user(request, username='joe'):
2626
def resolving_view(request, arg1, arg2):
2727
# see test_url_resolving in tests.py
2828
return HttpResponse()
29-
30-
31-
def set_session(request):
32-
request.session['où'] = 'où'
33-
if not six.PY3:
34-
request.session['là'.encode('utf-8')] = 'là'.encode('utf-8')
35-
return render(request, 'basic.html')

0 commit comments

Comments
 (0)