Skip to content

Commit c4eeef2

Browse files
committed
Improve signals panel
1 parent e4cb445 commit c4eeef2

File tree

1 file changed

+18
-7
lines changed

1 file changed

+18
-7
lines changed

debug_toolbar/panels/signals.py

+18-7
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,17 @@ class SignalDebugPanel(DebugPanel):
3838
def nav_title(self):
3939
return _("Signals")
4040

41+
def nav_subtitle(self):
42+
signals = self.get_stats()['signals']
43+
num_receivers = sum(len(s[2]) for s in signals)
44+
num_signals = len(signals)
45+
return '%d %s from %d %s' % (
46+
num_receivers,
47+
(num_receivers == 1) and 'receiver' or 'receivers',
48+
num_signals,
49+
(num_signals == 1) and 'signal' or 'signals',
50+
)
51+
4152
def title(self):
4253
return _("Signals")
4354

@@ -60,10 +71,7 @@ def signals(self):
6071

6172
def process_response(self, request, response):
6273
signals = []
63-
keys = self.signals.keys()
64-
keys.sort()
65-
for name in keys:
66-
signal = self.signals[name]
74+
for name, signal in sorted(self.signals.items(), key=lambda x: x[0]):
6775
if signal is None:
6876
continue
6977
receivers = []
@@ -72,12 +80,15 @@ def process_response(self, request, response):
7280
receiver = receiver()
7381
if receiver is None:
7482
continue
83+
84+
receiver = getattr(receiver, '__wraps__', receiver)
85+
receiver_name = getattr(receiver, '__name__', str(receiver))
7586
if getattr(receiver, 'im_self', None) is not None:
76-
text = "method %s on %s object" % (receiver.__name__, getattr(receiver.im_self, '__class__', type).__name__)
87+
text = "%s.%s" % (getattr(receiver.im_self, '__class__', type).__name__, receiver_name)
7788
elif getattr(receiver, 'im_class', None) is not None:
78-
text = "method %s on %s" % (receiver.__name__, receiver.im_class.__name__)
89+
text = "%s.%s" % (receiver.im_class.__name__, receiver_name)
7990
else:
80-
text = "function %s" % getattr(receiver, '__name__', str(receiver))
91+
text = "%s" % receiver_name
8192
receivers.append(text)
8293
signals.append((name, signal, receivers))
8394

0 commit comments

Comments
 (0)