Skip to content

Commit d1b0e56

Browse files
committed
Fixed leaking middleware for non-200 requests.
Thanks to Michael Elsdörfer for the report and patch.
1 parent f36b726 commit d1b0e56

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

debug_toolbar/middleware.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,10 @@ def process_response(self, request, response):
8383
'debug_toolbar/redirect.html',
8484
{'redirect_to': redirect_to}
8585
)
86-
if response.status_code != 200:
87-
return response
88-
for panel in self.debug_toolbars[request].panels:
89-
panel.process_response(request, response)
90-
if response['Content-Type'].split(';')[0] in _HTML_TYPES:
91-
response.content = replace_insensitive(smart_unicode(response.content), u'</body>', smart_unicode(self.debug_toolbars[request].render_toolbar() + u'</body>'))
86+
if response.status_code == 200:
87+
for panel in self.debug_toolbars[request].panels:
88+
panel.process_response(request, response)
89+
if response['Content-Type'].split(';')[0] in _HTML_TYPES:
90+
response.content = replace_insensitive(smart_unicode(response.content), u'</body>', smart_unicode(self.debug_toolbars[request].render_toolbar() + u'</body>'))
9291
del self.debug_toolbars[request]
9392
return response

0 commit comments

Comments
 (0)