Merge pull request #1281 from jdufresne/properties

matthiask · web-flow · commit e714e53c6fed · 2020-05-19T08:46:07.000+02:00
Replace .getAttribute() calls with the appropriate element property
diff --git a/debug_toolbar/static/debug_toolbar/js/toolbar.js b/debug_toolbar/static/debug_toolbar/js/toolbar.js
@@ -109,16 +109,16 @@
 
                 if (this.tagName === 'BUTTON') {
                     const form = this.closest('form');
-                    ajax_data.url = this.getAttribute('formaction');
+                    ajax_data.url = this.formAction;
 
                     if (form) {
                         ajax_data.body = new FormData(form);
-                        ajax_data.method = form.getAttribute('method') || 'POST';
+                        ajax_data.method = form.method.toUpperCase();
                     }
                 }
 
                 if (this.tagName === 'A') {
-                    ajax_data.url = this.getAttribute('href');
+                    ajax_data.url = this.href;
                 }
 
                 ajax(ajax_data.url, ajax_data).then(function(body) {

Original file line number	Diff line number	Diff line change
`@@ -109,16 +109,16 @@`
`109`	`109`
`110`	`110`	`if (this.tagName === 'BUTTON') {`
`111`	`111`	`const form = this.closest('form');`
`112`		`- ajax_data.url = this.getAttribute('formaction');`
	`112`	`+ ajax_data.url = this.formAction;`
`113`	`113`
`114`	`114`	`if (form) {`
`115`	`115`	`ajax_data.body = new FormData(form);`
`116`		`- ajax_data.method = form.getAttribute('method') \|\| 'POST';`
	`116`	`+ ajax_data.method = form.method.toUpperCase();`
`117`	`117`	`}`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`if (this.tagName === 'A') {`
`121`		`- ajax_data.url = this.getAttribute('href');`
	`121`	`+ ajax_data.url = this.href;`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`ajax(ajax_data.url, ajax_data).then(function(body) {`