Skip to content

Commit eff9128

Browse files
authored
Remove rem units from svg (#1942)
* Use css properties for height and width
1 parent d0f09b3 commit eff9128

File tree

4 files changed

+5
-6
lines changed

4 files changed

+5
-6
lines changed

.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,5 @@ htmlcov
1212
.tox
1313
geckodriver.log
1414
coverage.xml
15+
.direnv/
16+
.envrc

debug_toolbar/static/debug_toolbar/css/toolbar.css

+2
Original file line numberDiff line numberDiff line change
@@ -734,4 +734,6 @@
734734
#djDebug[data-theme="dark"] #djToggleThemeButton svg.theme-dark,
735735
#djDebug[data-theme="auto"] #djToggleThemeButton svg.theme-auto {
736736
display: block;
737+
height: 1rem;
738+
width: 1rem;
737739
}

debug_toolbar/templates/debug_toolbar/includes/theme_selector.html

-6
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
aria-hidden="true"
33
class="djdt-hidden theme-auto"
44
fill="currentColor"
5-
width="1rem"
6-
height="1rem"
75
viewBox="0 0 32 32"
86
version="1.1"
97
xmlns="http://www.w3.org/2000/svg"
@@ -15,8 +13,6 @@
1513
<svg
1614
aria-hidden="true"
1715
class="djdt-hidden theme-light"
18-
width="1rem"
19-
height="1rem"
2016
viewBox="0 0 24 24"
2117
fill="none"
2218
xmlns="http://www.w3.org/2000/svg"
@@ -31,8 +27,6 @@
3127
<svg
3228
aria-hidden="true"
3329
class="djdt-hidden theme-dark"
34-
width="1rem"
35-
height="1rem"
3630
viewBox="0 0 24 24"
3731
fill="none"
3832
xmlns="http://www.w3.org/2000/svg"

docs/changes.rst

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Pending
1313
paths aren't installed.
1414
* Introduce helper function ``debug_toolbar_urls`` to
1515
simplify installation.
16+
* Moved "1rem" height/width for SVGs to CSS properties.
1617

1718
4.4.2 (2024-05-27)
1819
------------------

0 commit comments

Comments
 (0)