use unittest.skipIf to skip tests invalid on PY3

Author: graingert

tests/tests.py

@@ -279,134 +279,135 @@ def module_func(*args, **kwargs):
     """Used by dispatch tests"""
     return 'blah'
 
-if not six.PY3:
-    class TrackingTestCase(BaseTestCase):
-        @classmethod
-        def class_method(cls, *args, **kwargs):
-            return 'blah'
-
-        def class_func(self, *args, **kwargs):
-            """Used by dispatch tests"""
-            return 'blah'
-
-        def test_pre_hook(self):
-            foo = {}
-
-            @pre_dispatch(module_func)
-            def test(**kwargs):
-                foo.update(kwargs)
-
-            self.assertTrue(hasattr(module_func, '__wrapped__'))
-            self.assertEqual(len(callbacks['before']), 1)
-
-            module_func('hi', foo='bar')
-
-            self.assertTrue('sender' in foo, foo)
-            # best we can do
-            self.assertEqual(foo['sender'].__name__, 'module_func')
-            self.assertTrue('start' in foo, foo)
-            self.assertTrue(foo['start'] > 0)
-            self.assertTrue('stop' not in foo, foo)
-            self.assertTrue('args' in foo, foo)
-            self.assertTrue(len(foo['args']), 1)
-            self.assertEqual(foo['args'][0], 'hi')
-            self.assertTrue('kwargs' in foo, foo)
-            self.assertTrue(len(foo['kwargs']), 1)
-            self.assertTrue('foo' in foo['kwargs'])
-            self.assertEqual(foo['kwargs']['foo'], 'bar')
-
-            callbacks['before'] = {}
-
-            @pre_dispatch(TrackingTestCase.class_func)
-            def test(**kwargs):
-                foo.update(kwargs)
-
-            self.assertTrue(hasattr(TrackingTestCase.class_func, '__wrapped__'))
-            self.assertEqual(len(callbacks['before']), 1)
-
-            self.class_func('hello', foo='bar')
-
-            self.assertTrue('sender' in foo, foo)
-            # best we can do
-            self.assertEqual(foo['sender'].__name__, 'class_func')
-            self.assertTrue('start' in foo, foo)
-            self.assertTrue(foo['start'] > 0)
-            self.assertTrue('stop' not in foo, foo)
-            self.assertTrue('args' in foo, foo)
-            self.assertTrue(len(foo['args']), 2)
-            self.assertEqual(foo['args'][1], 'hello')
-            self.assertTrue('kwargs' in foo, foo)
-            self.assertTrue(len(foo['kwargs']), 1)
-            self.assertTrue('foo' in foo['kwargs'])
-            self.assertEqual(foo['kwargs']['foo'], 'bar')
-
-            callbacks['before'] = {}
-
-            @pre_dispatch(TrackingTestCase.class_method)
-            def test(**kwargs):
-                foo.update(kwargs)
-
-            self.assertTrue(hasattr(TrackingTestCase.class_method, '__wrapped__'))
-            self.assertEqual(len(callbacks['before']), 1)
-
-            TrackingTestCase.class_method()
-
-            self.assertTrue('sender' in foo, foo)
-            # best we can do
-            self.assertEqual(foo['sender'].__name__, 'class_method')
-            self.assertTrue('start' in foo, foo)
-            self.assertTrue('stop' not in foo, foo)
-            self.assertTrue('args' in foo, foo)
-
-        def test_post_hook(self):
-            foo = {}
-
-            @post_dispatch(module_func)
-            def test(**kwargs):
-                foo.update(kwargs)
-
-            self.assertTrue(hasattr(module_func, '__wrapped__'))
-            self.assertEqual(len(callbacks['after']), 1)
-
-            module_func('hi', foo='bar')
-
-            self.assertTrue('sender' in foo, foo)
-            # best we can do
-            self.assertEqual(foo['sender'].__name__, 'module_func')
-            self.assertTrue('start' in foo, foo)
-            self.assertTrue(foo['start'] > 0)
-            self.assertTrue('stop' in foo, foo)
-            self.assertTrue(foo['stop'] > foo['start'])
-            self.assertTrue('args' in foo, foo)
-            self.assertTrue(len(foo['args']), 1)
-            self.assertEqual(foo['args'][0], 'hi')
-            self.assertTrue('kwargs' in foo, foo)
-            self.assertTrue(len(foo['kwargs']), 1)
-            self.assertTrue('foo' in foo['kwargs'])
-            self.assertEqual(foo['kwargs']['foo'], 'bar')
-
-            callbacks['after'] = {}
-
-            @post_dispatch(TrackingTestCase.class_func)
-            def test(**kwargs):
-                foo.update(kwargs)
-
-            self.assertTrue(hasattr(TrackingTestCase.class_func, '__wrapped__'))
-            self.assertEqual(len(callbacks['after']), 1)
-
-            self.class_func('hello', foo='bar')
-
-            self.assertTrue('sender' in foo, foo)
-            # best we can do
-            self.assertEqual(foo['sender'].__name__, 'class_func')
-            self.assertTrue('start' in foo, foo)
-            self.assertTrue(foo['start'] > 0)
-            self.assertTrue('stop' in foo, foo)
-            self.assertTrue(foo['stop'] > foo['start'])
-            self.assertTrue('args' in foo, foo)
-            self.assertTrue(len(foo['args']), 2)
-            self.assertEqual(foo['args'][1], 'hello')
-            self.assertTrue('kwargs' in foo, foo)
-            self.assertTrue(len(foo['kwargs']), 1)
-            self.assertTrue('foo' in foo['kwargs'])
-            self.assertEqual(foo['kwargs']['foo'], 'bar')
+
+@unittest.skipIf(six.PY3, "replace_call is not supported on Python 3")
+class TrackingTestCase(BaseTestCase):
+    @classmethod
+    def class_method(cls, *args, **kwargs):
+        return 'blah'
+
+    def class_func(self, *args, **kwargs):
+        """Used by dispatch tests"""
+        return 'blah'
+
+    def test_pre_hook(self):
+        foo = {}
+
+        @pre_dispatch(module_func)
+        def test(**kwargs):
+            foo.update(kwargs)
+
+        self.assertTrue(hasattr(module_func, '__wrapped__'))
+        self.assertEqual(len(callbacks['before']), 1)
+
+        module_func('hi', foo='bar')
+
+        self.assertTrue('sender' in foo, foo)
+        # best we can do
+        self.assertEqual(foo['sender'].__name__, 'module_func')
+        self.assertTrue('start' in foo, foo)
+        self.assertTrue(foo['start'] > 0)
+        self.assertTrue('stop' not in foo, foo)
+        self.assertTrue('args' in foo, foo)
+        self.assertTrue(len(foo['args']), 1)
+        self.assertEqual(foo['args'][0], 'hi')
+        self.assertTrue('kwargs' in foo, foo)
+        self.assertTrue(len(foo['kwargs']), 1)
+        self.assertTrue('foo' in foo['kwargs'])
+        self.assertEqual(foo['kwargs']['foo'], 'bar')
+
+        callbacks['before'] = {}
+
+        @pre_dispatch(TrackingTestCase.class_func)
+        def test(**kwargs):
+            foo.update(kwargs)
+
+        self.assertTrue(hasattr(TrackingTestCase.class_func, '__wrapped__'))
+        self.assertEqual(len(callbacks['before']), 1)
+
+        self.class_func('hello', foo='bar')
+
+        self.assertTrue('sender' in foo, foo)
+        # best we can do
+        self.assertEqual(foo['sender'].__name__, 'class_func')
+        self.assertTrue('start' in foo, foo)
+        self.assertTrue(foo['start'] > 0)
+        self.assertTrue('stop' not in foo, foo)
+        self.assertTrue('args' in foo, foo)
+        self.assertTrue(len(foo['args']), 2)
+        self.assertEqual(foo['args'][1], 'hello')
+        self.assertTrue('kwargs' in foo, foo)
+        self.assertTrue(len(foo['kwargs']), 1)
+        self.assertTrue('foo' in foo['kwargs'])
+        self.assertEqual(foo['kwargs']['foo'], 'bar')
+
+        callbacks['before'] = {}
+
+        @pre_dispatch(TrackingTestCase.class_method)
+        def test(**kwargs):
+            foo.update(kwargs)
+
+        self.assertTrue(hasattr(TrackingTestCase.class_method, '__wrapped__'))
+        self.assertEqual(len(callbacks['before']), 1)
+
+        TrackingTestCase.class_method()
+
+        self.assertTrue('sender' in foo, foo)
+        # best we can do
+        self.assertEqual(foo['sender'].__name__, 'class_method')
+        self.assertTrue('start' in foo, foo)
+        self.assertTrue('stop' not in foo, foo)
+        self.assertTrue('args' in foo, foo)
+
+    def test_post_hook(self):
+        foo = {}
+
+        @post_dispatch(module_func)
+        def test(**kwargs):
+            foo.update(kwargs)
+
+        self.assertTrue(hasattr(module_func, '__wrapped__'))
+        self.assertEqual(len(callbacks['after']), 1)
+
+        module_func('hi', foo='bar')
+
+        self.assertTrue('sender' in foo, foo)
+        # best we can do
+        self.assertEqual(foo['sender'].__name__, 'module_func')
+        self.assertTrue('start' in foo, foo)
+        self.assertTrue(foo['start'] > 0)
+        self.assertTrue('stop' in foo, foo)
+        self.assertTrue(foo['stop'] > foo['start'])
+        self.assertTrue('args' in foo, foo)
+        self.assertTrue(len(foo['args']), 1)
+        self.assertEqual(foo['args'][0], 'hi')
+        self.assertTrue('kwargs' in foo, foo)
+        self.assertTrue(len(foo['kwargs']), 1)
+        self.assertTrue('foo' in foo['kwargs'])
+        self.assertEqual(foo['kwargs']['foo'], 'bar')
+
+        callbacks['after'] = {}
+
+        @post_dispatch(TrackingTestCase.class_func)
+        def test(**kwargs):
+            foo.update(kwargs)
+
+        self.assertTrue(hasattr(TrackingTestCase.class_func, '__wrapped__'))
+        self.assertEqual(len(callbacks['after']), 1)
+
+        self.class_func('hello', foo='bar')
+
+        self.assertTrue('sender' in foo, foo)
+        # best we can do
+        self.assertEqual(foo['sender'].__name__, 'class_func')
+        self.assertTrue('start' in foo, foo)
+        self.assertTrue(foo['start'] > 0)
+        self.assertTrue('stop' in foo, foo)
+        self.assertTrue(foo['stop'] > foo['start'])
+        self.assertTrue('args' in foo, foo)
+        self.assertTrue(len(foo['args']), 2)
+        self.assertEqual(foo['args'][1], 'hello')
+        self.assertTrue('kwargs' in foo, foo)
+        self.assertTrue(len(foo['kwargs']), 1)
+        self.assertTrue('foo' in foo['kwargs'])
+        self.assertEqual(foo['kwargs']['foo'], 'bar')