8000 Fix Selnium test by jdufresne · Pull Request #1339 · django-commons/django-debug-toolbar · GitHub
Skip to content

Fix Selnium test - #1339

Closed
jdufresne wants to merge 1 commit into
django-commons:masterfrom
jdufresne:selenium
Closed

Fix Selnium test#1339
jdufresne wants to merge 1 commit into
django-commons:masterfrom
jdufresne:selenium

Conversation

@jdufresne

Copy link
Copy Markdown
Contributor

There exists 2 rendered templates:

  • jinja2/basic.jinja
  • base.html

There exists 2 rendered templates:

- jinja2/basic.jinja
- base.html

@tim-schilling tim-schilling left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that this would validate that the base.html template is also rendered. Or at least that's what I had done in my local changes for starting on enabling these tests in Travis.

@jdufresne

Copy link
Copy Markdown
Contributor Author

Sounds good, I will add that.

OTOH, if you already have the work ready, feel free to throw up a PR and I'll close this one.

@tim-schilling

Copy link
Copy Markdown
Member

Closing this PR in favor of #1343.

@jdufresne
jdufresne deleted the selenium branch September 26, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants