From 1566b4d121c9d950de83372d5392fc9760fd447a Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Thu, 29 Jan 2015 19:33:04 +0100 Subject: [PATCH] logging: do not change the root logger's level Fixes https://github.com/django-debug-toolbar/django-debug-toolbar/issues/572 --- debug_toolbar/panels/logging.py | 1 - tests/panels/test_logging.py | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/debug_toolbar/panels/logging.py b/debug_toolbar/panels/logging.py index 1ee19cefe..b451019cd 100644 --- a/debug_toolbar/panels/logging.py +++ b/debug_toolbar/panels/logging.py @@ -50,7 +50,6 @@ def emit(self, record): collector = LogCollector() logging_handler = ThreadTrackingHandler(collector) -logging.root.setLevel(logging.NOTSET) logging.root.addHandler(logging_handler) diff --git a/tests/panels/test_logging.py b/tests/panels/test_logging.py index 288efadf1..306481941 100644 --- a/tests/panels/test_logging.py +++ b/tests/panels/test_logging.py @@ -16,6 +16,10 @@ def setUp(self): self.logger = logging.getLogger(__name__) collector.clear_collection() + # Assume the root logger has been configured with level=DEBUG. + # Previously DDT forcefully set this itself to 0 (NOTSET). + logging.root.setLevel(logging.DEBUG) + def test_happy_case(self): self.logger.info('Nothing to see here, move along!')