Skip to content

Fix Django 1.0 middleware function compatibility #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2016

Conversation

ryankask
Copy link
Contributor

This patch addresses the issue mentioned in #878.

There was a check that raised a warning that I had to deal with in the test. Please let me know if I should amend this in any way.

@ryankask ryankask force-pushed the functional-middleware-fix branch from ebd2e64 to 1f5531a Compare September 16, 2016 18:36
@codecov-io
Copy link

codecov-io commented Sep 16, 2016

Current coverage is 77.00% (diff: 100%)

Merging #879 into master will increase coverage by 0.13%

@@             master       #879   diff @@
==========================================
  Files            30         30          
  Lines          1634       1635     +1   
  Methods           0          0          
  Messages          0          0          
  Branches        244        244          
==========================================
+ Hits           1256       1259     +3   
  Misses          302        302          
+ Partials         76         74     -2   

Powered by Codecov. Last update e7a9ed0...1f5531a

@matthiask matthiask merged commit ef4bc2b into django-commons:master Sep 17, 2016
@matthiask
Copy link
Member

Thanks!

@jhancia
Copy link

jhancia commented Sep 20, 2016

Hello, really appreciate this package. Any chance we could have a pypi release to allow for django 1.10 compatibility? Thank you!

ryneeverett pushed a commit to ryneeverett/django-debug-toolbar that referenced this pull request Oct 2, 2016
…ware-fix

Fix Django 1.10 function middleware compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants