FFFF Support recursive template extension. by ryneeverett · Pull Request #885 · django-commons/django-debug-toolbar · GitHub
Skip to content

Support recursive template extension. - #885

Merged
aaugustin merged 1 commit into
django-commons:masterfrom
ryneeverett:template-recursion-broken-git-history
Nov 7, 2016
Merged

Support recursive template extension.#885
aaugustin merged 1 commit into
django-commons:masterfrom
ryneeverett:template-recursion-broken-git-history

Conversation

@ryneeverett

Copy link
Copy Markdown
Contributor

From the django 1.9 release
notes
:

  • Django template loaders can now extend templates recursively.

...

Django template loaders have been updated to allow recursive template
extending. This change necessitated a new template loader API. The old
load_template() and load_template_sources() methods are now
deprecated.

Prior to this patch, when a template is recursively extended the latest
template in the template loaders is displayed regardless of the template
origin since the proper template can no longer be disambiguated by
template_name.

From the [django 1.9 release
notes](https://docs.djangoproject.com/en/1.10/releases/1.9/):

> - Django template loaders can now extend templates recursively.

...

> Django template loaders have been updated to allow recursive template
> extending. This change necessitated a new template loader API. The old
> load_template() and load_template_sources() methods are now
> deprecated.

Prior to this patch, when a template is recursively extended the latest
template in the template loaders is displayed regardless of the template
origin since the proper template can no longer be disambiguated by
template_name.
@codecov-io

codecov-io commented Oct 2, 2016

Copy link
Copy Markdown

Current coverage is 76.63% (diff: 19.04%)

Merging #885 into master will decrease coverage by 0.36%

@@             master       #885   diff @@
==========================================
  Files            30         30          
  Lines          1635       1648    +13   
  Methods           0          0          
  Messages          0          0          
  Branches        244        245     +1   
==========================================
+ Hits           1259       1263     +4   
- Misses          302        311     +9   
  Partials         74         74          

Powered by Codecov. Last update 637b0b7...aff9e3e

@matthiask matthiask left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@aaugustin
aaugustin merged commit 61b1bdc into django-commons:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants