Skip to content

Commit c6e93d7

Browse files
committed
fix cached or default expression swallowing falsy value
1 parent 2047d22 commit c6e93d7

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

django_prometheus/cache/backends/django_memcached_consul.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ def get(self, key, default=None, version=None):
1515
cached = super().get(key, default=None, version=version)
1616
if cached is not None:
1717
django_cache_hits_total.labels(backend="django_memcached_consul").inc()
18-
else:
19-
django_cache_misses_total.labels(backend="django_memcached_consul").inc()
20-
return cached or default
18+
return cached
19+
20+
django_cache_misses_total.labels(backend="django_memcached_consul").inc()
21+
return cached

django_prometheus/cache/backends/filebased.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ def get(self, key, default=None, version=None):
1515
cached = super().get(key, default=None, version=version)
1616
if cached is not None:
1717
django_cache_hits_total.labels(backend="filebased").inc()
18-
else:
19-
django_cache_misses_total.labels(backend="filebased").inc()
20-
return cached or default
18+
return cached
19+
20+
django_cache_misses_total.labels(backend="filebased").inc()
21+
return cached

django_prometheus/cache/backends/locmem.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ def get(self, key, default=None, version=None):
1515
cached = super().get(key, default=None, version=version)
1616
if cached is not None:
1717
django_cache_hits_total.labels(backend="locmem").inc()
18-
else:
19-
django_cache_misses_total.labels(backend="locmem").inc()
20-
return cached or default
18+
return cached
19+
20+
django_cache_misses_total.labels(backend="locmem").inc()
21+
return cached

0 commit comments

Comments
 (0)