test(): templatetags test

Author: gbataille

simple_history/templatetags/getattributes.py

@@ -6,7 +6,6 @@
 def getattribute(value, arg):
     """Gets an attribute of an object dynamically from a string name"""
 
-    if hasattr(value, str(arg)):
-        return getattr(value, arg)
+    return getattr(value, arg, None)
 
 register.filter('getattribute', getattribute)

simple_history/tests/tests/test_templatetags.py

@@ -0,0 +1,16 @@
+from simple_history.templatetags.getattributes import getattribute
+
+from django.test import TestCase
+
+
+class Foo(object):
+    bar = "bar"
+
+
+class TestGetAttributes(TestCase):
+
+    def test_get_existing_attributes_return_it(self):
+        self.assertEqual(getattribute(Foo(), 'bar'), 'bar')
+
+    def test_get_missing_attributes_return_None(self):
+        self.assertIsNone(getattribute(Foo(), 'baz'))