Core: Warn & fill jQuery.trim

Fixes jquerygh-325
Closes jquerygh-331

Author: mgol

src/core.js

@@ -2,7 +2,11 @@
 var oldInit = jQuery.fn.init,
 	oldFind = jQuery.find,
 	rattrHashTest = /\[(\s*[-\w]+\s*)([~|^$*]?=)\s*([-\w#]*?#[-\w#]*)\s*\]/,
-	rattrHashGlob = /\[(\s*[-\w]+\s*)([~|^$*]?=)\s*([-\w#]*?#[-\w#]*)\s*\]/g;
+	rattrHashGlob = /\[(\s*[-\w]+\s*)([~|^$*]?=)\s*([-\w#]*?#[-\w#]*)\s*\]/g,
+
+	// Support: Android <=4.0 only
+	// Make sure we trim BOM and NBSP
+	rtrim = /^[\s\uFEFF\xA0]+|[\s\uFEFF\xA0]+$/g;
 
 jQuery.fn.init = function( arg1 ) {
 	var args = Array.prototype.slice.call( arguments );
@@ -60,15 +64,15 @@ for ( findProp in oldFind ) {
 }
 
 // The number of elements contained in the matched element set
-jQuery.fn.size = function() {
-	migrateWarn( "jQuery.fn.size() is deprecated and removed; use the .length property" );
+migrateWarnFunc( jQuery.fn, "size", function() {
 	return this.length;
-};
+},
+"jQuery.fn.size() is deprecated and removed; use the .length property" );
 
-jQuery.parseJSON = function() {
-	migrateWarn( "jQuery.parseJSON is deprecated; use JSON.parse" );
+migrateWarnFunc( jQuery, "parseJSON", function() {
 	return JSON.parse.apply( null, arguments );
-};
+},
+"jQuery.parseJSON is deprecated; use JSON.parse" );
 
 migrateWarnFunc( jQuery, "holdReady", jQuery.holdReady,
 	"jQuery.holdReady is deprecated" );
@@ -82,6 +86,16 @@ migrateWarnProp( jQuery.expr, "filters", jQuery.expr.pseudos,
 migrateWarnProp( jQuery.expr, ":", jQuery.expr.pseudos,
 	"jQuery.expr[':'] is deprecated; use jQuery.expr.pseudos" );
 
+// Prior to jQuery 3.1.1 there were internal refs so we don't warn there
+if ( jQueryVersionSince( "3.1.1" ) ) {
+	migrateWarnFunc( jQuery, "trim", function( text ) {
+		return text == null ?
+			"" :
+			( text + "" ).replace( rtrim, "" );
+	},
+	"jQuery.trim is deprecated; use String.prototype.trim" );
+}
+
 // Prior to jQuery 3.2 there were internal refs so we don't warn there
 if ( jQueryVersionSince( "3.2.0" ) ) {
 	migrateWarnFunc( jQuery, "nodeName", function( elem, name ) {

test/core.js

@@ -370,15 +370,63 @@ QUnit.test( "jQuery.holdReady (warn only)", function( assert ) {
 	} );
 } );
 
+QUnit[ jQueryVersionSince( "3.1.1" ) ? "test" : "skip" ]( "jQuery.trim", function( assert ) {
+	assert.expect( 26 );
+
+	var nbsp = String.fromCharCode( 160 );
+
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( "hello  " ), "hello", "trailing space" );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( "  hello" ), "hello", "leading space" );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( "  hello   " ), "hello", "space on both sides" );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( "  " + nbsp + "hello  " + nbsp + " " ), "hello", " " );
+	} );
+
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim(), "", "Nothing in." );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( undefined ), "", "Undefined" );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( null ), "", "Null" );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( 5 ), "5", "Number" );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( false ), "false", "Boolean" );
+	} );
+
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( " " ), "", "space should be trimmed" );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( "ipad\xA0" ), "ipad", "nbsp should be trimmed" );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( "\uFEFF" ), "", "zwsp should be trimmed" );
+	} );
+	expectWarning( assert, "jQuery.trim", 1, function() {
+		assert.equal( jQuery.trim( "\uFEFF \xA0! | \uFEFF" ), "! |", "leading/trailing should be trimmed" );
+	} );
+} );
+
 QUnit[ jQueryVersionSince( "3.2.0" ) ? "test" : "skip" ]( "jQuery.nodeName", function( assert ) {
 	assert.expect( 2 );
 
 	expectWarning( assert, "jQuery.nodeName", function() {
 		var div = document.createElement( "div" );
 
 		assert.equal( jQuery.nodeName( div, "div" ), true, "it's a div" );
-	})
-});
+	} );
+} );
 
 QUnit[ jQueryVersionSince( "3.3.0" ) ? "test" : "skip" ]( "jQuery.isFunction", function( assert ) {
 	assert.expect( 4 );

warnings.md

@@ -243,6 +243,13 @@ See jQuery-ui [commit](https://github.com/jquery/jquery-ui/commit/c0093b599fcd58
 **Solution:** Remove any uses of `jQuery.cssProps` in application code.
 
 #### JQMIGRATE: jQuery.isArray is deprecated; use Array.isArray
+
 **Cause:** Older versions of JavaScript made it difficult to determine if a particular object was a true Array, so jQuery provided a cross-browser function to do the work. The browsers supported by jQuery 3.0 all provide a standard method for this purpose.
 
 **Solution:** Replace any calls to `jQuery.isArray` with `Array.isArray`.
+
+#### JQMIGRATE: jQuery.trim is deprecated; use String.prototype.trim
+
+**Cause:** Older versions of IE & Android Browser didn't implement a method to `trim` strings so jQuery provided a cross-browser implementation. The browsers supported by jQuery 3.0 all provide a standard method for this purpose.
+
+**Solution:** Replace any calls to `jQuery.trim( text )` with `text.trim()` if you know `text` is a string; otherwise, you can replace it with `text == null ? "" : text.trim()`.