Skip to content

Commit ce91b63

Browse files
committed
Try using $.extend to make new event; still fails some unit tests.
1 parent 66f9e12 commit ce91b63

File tree

1 file changed

+6
-19
lines changed

1 file changed

+6
-19
lines changed

ui/jquery.ui.widget.js

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -376,27 +376,14 @@ $.Widget.prototype = {
376376
_trigger: function( type, event, data ) {
377377
var callback = this.options[ type ],
378378
args;
379-
380-
event = $.Event( event );
381-
event.type = ( type === this.widgetEventPrefix ?
382-
type :
383-
this.widgetEventPrefix + type ).toLowerCase();
379+
380+
event = $.extend( $.Event(), event, {
381+
type: (this.widgetEventPrefix + (type === this.widgetEventPrefix ? "" : type)).toLowerCase(),
382+
originalEvent: event,
383+
target: this.element[0]
384+
});
384385
data = data || {};
385386

386-
// copy original event properties over to the new event
387-
// this would happen if we could call $.event.fix instead of $.Event
388-
// but we don't have a way to force an event to be fixed multiple times
389-
if ( event.originalEvent ) {
390-
for ( var i = $.event.props.length, prop; i; ) {
391-
prop = $.event.props[ --i ];
392-
event[ prop ] = event.originalEvent[ prop ];
393-
}
394-
}
395-
396-
// the original event may come from any element
397-
// so we need to reset the target on the new event
398-
event.target = this.element[0];
399-
400387
this.element.trigger( event, data );
401388

402389
args = $.isArray( data ) ?

0 commit comments

Comments
 (0)