Build: Update jscs and lint files

Fixes jquerygh-2056

Author: markelog

.jscsrc

@@ -1,6 +1,10 @@
 {
 	"preset": "jquery",
 
+	// remove after https://github.com/jscs-dev/node-jscs/issues/1685
+	// and https://github.com/jscs-dev/node-jscs/issues/1686
+	"requireCapitalizedComments": null,
+
 	"excludeFiles": [ "external", "src/intro.js", "src/outro.js",
-		"test/node_smoke_tests/lib/ensure_iterability.js" ]
+		"test/node_smoke_tests/lib/ensure_iterability.js", "node_modules" ]
 }

Gruntfile.js

@@ -20,7 +20,7 @@ module.exports = function( grunt ) {
 	// But our modules can
 	delete srcHintOptions.onevar;
 
-	grunt.initConfig({
+	grunt.initConfig( {
 		pkg: grunt.file.readJSON( "package.json" ),
 		dst: readOptionalJSON( "dist/.destination.json" ),
 		"compare_size": {
@@ -53,6 +53,7 @@ module.exports = function( grunt ) {
 					"core",
 					"selector"
 				],
+
 				// Exclude specified modules if the module matching the key is removed
 				removeWith: {
 					ajax: [ "manipulation/_evalUrl", "event/ajax" ],
@@ -108,7 +109,12 @@ module.exports = function( grunt ) {
 			gruntfile: "Gruntfile.js",
 
 			// Check parts of tests that pass
-			test: [ "test/data/testrunner.js", "test/unit/animation.js", "test/unit/tween.js" ],
+			test: [
+				"test/data/testrunner.js",
+				"test/unit/animation.js",
+				"test/unit/tween.js",
+				"test/unit/wrap.js"
+			],
 			release: [ "build/*.js", "!build/release-notes.js" ],
 			tasks: "build/tasks/*.js"
 		},
@@ -162,7 +168,7 @@ module.exports = function( grunt ) {
 				}
 			}
 		}
-	});
+	} );
 
 	// Load grunt tasks from NPM packages
 	require( "load-grunt-tasks" )( grunt );
@@ -177,7 +183,7 @@ module.exports = function( grunt ) {
 	grunt.registerTask( "test", [ "test_fast", "promises_aplus_tests" ] );
 
 	// Short list as a high frequency watch task
-	grunt.registerTask( "dev", [ "build:*:*", "lint", "uglify", "remove_map_comment", "dist:*" ] );
+	grunt.registerTask( "dev", [ "build:*:*", "uglify", "remove_map_comment", "dist:*" ] );
 
 	grunt.registerTask( "default", [ "dev", "test_fast", "compare_size" ] );
 };

build/release.js

@@ -9,7 +9,7 @@ module.exports = function( Release ) {
 
 		npmTags = Release.npmTags;
 
-	Release.define({
+	Release.define( {
 		npmPublish: true,
 		issueTracker: "github",
 		/**
@@ -36,6 +36,7 @@ module.exports = function( Release ) {
 		 * for publishing the distribution repo instead
 		 */
 		npmTags: function() {
+
 			// origRepo is not defined if dist was skipped
 			Release.dir.repo = Release.dir.origRepo || Release.dir.repo;
 			return npmTags();
@@ -47,9 +48,9 @@ module.exports = function( Release ) {
 		dist: function( callback ) {
 			cdn.makeArchives( Release, function() {
 				dist( Release, callback );
-			});
+			} );
 		}
-	});
+	} );
 };
 
 module.exports.dependencies = [

build/release/cdn.js

@@ -29,13 +29,14 @@ var
 function makeReleaseCopies( Release ) {
 	shell.mkdir( "-p", cdnFolder );
 
-	Object.keys( releaseFiles ).forEach(function( key ) {
+	Object.keys( releaseFiles ).forEach( function( key ) {
 		var text,
 			builtFile = releaseFiles[ key ],
 			unpathedFile = key.replace( /VER/g, Release.newVersion ),
 			releaseFile = cdnFolder + "/" + unpathedFile;
 
 		if ( /\.map$/.test( releaseFile ) ) {
+
 			// Map files need to reference the new uncompressed name;
 			// assume that all files reside in the same directory.
 			// "file":"jquery.min.js","sources":["jquery.js"]
@@ -47,7 +48,7 @@ function makeReleaseCopies( Release ) {
 		} else if ( builtFile !== releaseFile ) {
 			shell.cp( "-f", builtFile, releaseFile );
 		}
-	});
+	} );
 }
 
 function makeArchives( Release, callback ) {
@@ -75,23 +76,23 @@ function makeArchives( Release, callback ) {
 
 		output.on( "error", function( err ) {
 			throw err;
-		});
+		} );
 
 		archiver.pipe( output );
 
-		files = files.map(function( item ) {
+		files = files.map( function( item ) {
 			return "dist" + ( rver.test( item ) ? "/cdn" : "" ) + "/" +
 				item.replace( rver, Release.newVersion );
-		});
+		} );
 
 		sum = Release.exec( "md5sum " + files.join( " " ), "Error retrieving md5sum" );
 		fs.writeFileSync( md5file, sum );
 		files.push( md5file );
 
-		files.forEach(function( file ) {
+		files.forEach( function( file ) {
 			archiver.append( fs.createReadStream( file ),
 				{ name: path.basename( file ) } );
-		});
+		} );
 
 		archiver.finalize();
 	}
@@ -104,9 +105,9 @@ function makeArchives( Release, callback ) {
 		makeArchive( "mscdn", msFilesCDN, callback );
 	}
 
-	buildGoogleCDN(function() {
+	buildGoogleCDN( function() {
 		buildMicrosoftCDN( callback );
-	});
+	} );
 }
 
 module.exports = {

build/release/dist.js

@@ -5,6 +5,7 @@ module.exports = function( Release, complete ) {
 		shell = require( "shelljs" ),
 		pkg = require( Release.dir.repo + "/package.json" ),
 		distRemote = Release.remote.replace( "jquery.git", "jquery-dist.git" ),
+
 		// These files are included with the distribution
 		files = [
 			"src",
@@ -34,15 +35,15 @@ module.exports = function( Release, complete ) {
 	 * Generate bower file for jquery-dist
 	 */
 	function generateBower() {
-		return JSON.stringify({
+		return JSON.stringify( {
 			name: pkg.name,
 			main: pkg.main,
 			license: "MIT",
 			ignore: [
 				"package.json"
 			],
 			keywords: pkg.keywords
-		}, null, 2);
+		}, null, 2 );
 	}
 
 	/**
@@ -57,14 +58,14 @@ module.exports = function( Release, complete ) {
 			"dist/jquery.js",
 			"dist/jquery.min.js",
 			"dist/jquery.min.map"
-		].forEach(function( file ) {
+		].forEach( function( file ) {
 			shell.cp( Release.dir.repo + "/" + file, distFolder );
-		});
+		} );
 
 		// Copy other files
-		files.forEach(function( file ) {
+		files.forEach( function( file ) {
 			shell.cp( "-r", Release.dir.repo + "/" + file, Release.dir.dist );
-		});
+		} );
 
 		// Write generated bower file
 		fs.writeFileSync( Release.dir.dist + "/bower.json", generateBower() );

build/release/ensure-sizzle.js

@@ -8,7 +8,7 @@ var fs = require( "fs" ),
  * @param {Function(string)} callback
  */
 function getLatestSizzle( callback ) {
-	npm.load(function( err, npm ) {
+	npm.load( function( err, npm ) {
 		if ( err ) {
 			throw err;
 		}
@@ -17,8 +17,8 @@ function getLatestSizzle( callback ) {
 				throw err;
 			}
 			callback( Object.keys( info )[ 0 ] );
-		});
-	});
+		} );
+	} );
 }
 
 /**
@@ -29,11 +29,12 @@ function getLatestSizzle( callback ) {
 function ensureSizzle( Release, callback ) {
 	console.log();
 	console.log( "Checking Sizzle version..." );
-	getLatestSizzle(function( latest ) {
+	getLatestSizzle( function( latest ) {
 		var match = rversion.exec( fs.readFileSync( sizzleLoc, "utf8" ) ),
 			version = match ? match[ 1 ] : "Not Found";
 
 		if ( version !== latest ) {
+
 			// colors is inherited from jquery-release
 			console.log(
 				"The Sizzle version in the src folder (" + version.red +
@@ -44,7 +45,7 @@ function ensureSizzle( Release, callback ) {
 			console.log( "Sizzle is latest (" + latest.green + ")" );
 			callback();
 		}
-	});
+	} );
 }
 
 module.exports = ensureSizzle;

build/release/release-notes.js

@@ -3,16 +3,16 @@
  * jQuery Release Note Generator
  */
 
-var http = require("http"),
+var http = require( "http" ),
 	extract = /<a href="\/ticket\/(\d+)" title="View ticket">(.*?)<[^"]+"component">\s*(\S+)/g,
-	version = process.argv[2];
+	version = process.argv[ 2 ];
 
 if ( !/^\d+\.\d+/.test( version ) ) {
 	console.error( "Invalid version number: " + version );
 	process.exit( 1 );
 }
 
-http.request({
+http.request( {
 	host: "bugs.jquery.com",
 	port: 80,
 	method: "GET",
@@ -23,34 +23,36 @@ http.request({
 
 	res.on( "data", function( chunk ) {
 		data.push( chunk );
-	});
+	} );
 
 	res.on( "end", function() {
 		var match, cur, cat,
-			file = data.join("");
+			file = data.join( "" );
 
-		while ( (match = extract.exec( file )) ) {
-			if ( "#" + match[1] !== match[2] ) {
-				cat = match[3];
+		while ( ( match = extract.exec( file ) ) ) {
+			if ( "#" + match[ 1 ] !== match[ 2 ] ) {
+				cat = match[ 3 ];
 
 				if ( !cur || cur !== cat ) {
 					if ( cur ) {
-						console.log("</ul>");
+						console.log( "</ul>" );
 					}
 					cur = cat;
-					console.log( "<h3>" + cat.charAt(0).toUpperCase() + cat.slice(1) + "</h3>" );
-					console.log("<ul>");
+					console.log(
+						"<h3>" + cat.charAt( 0 ).toUpperCase() + cat.slice( 1 ) + "</h3>"
+					);
+					console.log( "<ul>" );
 				}
 
 				console.log(
-					"  <li><a href=\"http://bugs.jquery.com/ticket/" + match[1] + "\">#" +
-					match[1] + ": " + match[2] + "</a></li>"
+					"  <li><a href=\"http://bugs.jquery.com/ticket/" + match[ 1 ] + "\">#" +
+					match[ 1 ] + ": " + match[ 2 ] + "</a></li>"
 				);
 			}
 		}
 		if ( cur ) {
-			console.log("</ul>");
+			console.log( "</ul>" );
 		}
 
-	});
-}).end();
+	} );
+} ).end();