Skip to content

Commit 7b9813c

Browse files
committed
Selectmenu: improved event handling, fixed tabindex when disabled
1 parent c0864df commit 7b9813c

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

ui/jquery.ui.selectmenu.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -302,8 +302,7 @@ $.widget( "ui.selectmenu", {
302302
event.stopImmediatePropagation();
303303
},
304304
click: function( event ) {
305-
// return false needed to prevent browser from following the anchor
306-
return false;
305+
event.preventDefault();
307306
},
308307
keydown: function( event ) {
309308
switch (event.keyCode) {
@@ -367,7 +366,7 @@ $.widget( "ui.selectmenu", {
367366
this.button.attr( "tabindex", -1 );
368367
} else {
369368
this.element.removeAttr( "disabled" );
370-
this.button.attr( "tabindex", 1 );
369+
this.button.attr( "tabindex", 0 );
371370
}
372371
this.menu.attr( "aria-disabled", value );
373372
this.close();

0 commit comments

Comments
 (0)