Skip to content

Commit 9057dc0

Browse files
Fix trentrichardson#689 - step option not being set for select dropdowns
1 parent d4b12fb commit 9057dc0

6 files changed

+23
-23
lines changed

dist/i18n/jquery-ui-timepicker-de.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/* Written by Marvin */
33
(function($) {
44
$.timepicker.regional['de'] = {
5-
timeOnlyTitle: 'Zeit Wählen',
5+
timeOnlyTitle: 'Zeit wählen',
66
timeText: 'Zeit',
77
hourText: 'Stunde',
88
minuteText: 'Minute',

dist/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ <h3>Requirements</h3>
124124

125125
<br />
126126
<h3>Version</h3>
127-
<p>Version 1.4.3</p>
127+
<p>Version 1.4.4</p>
128128

129129
<p>Last updated on 2013-11-30</p>
130130
<p>jQuery Timepicker Addon is currently available for use in all personal or commercial projects under the MIT license.</p>

dist/jquery-ui-timepicker-addon.js

+10-10
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
/*! jQuery Timepicker Addon - v1.4.3 - 2013-11-30
1+
/*! jQuery Timepicker Addon - v1.4.4 - 2013-11-30
22
* http://trentrichardson.com/examples/timepicker
3-
* Copyright (c) 2013 Trent Richardson; Licensed MIT */
3+
* Copyright (c) 2014 Trent Richardson; Licensed MIT */
44
(function ($) {
55

66
/*
@@ -16,7 +16,7 @@
1616
*/
1717
$.extend($.ui, {
1818
timepicker: {
19-
version: "1.4.3"
19+
version: "1.4.4"
2020
}
2121
});
2222

@@ -668,23 +668,23 @@
668668
microsecMax = parseInt((this._defaults.microsecMax - ((this._defaults.microsecMax - this._defaults.microsecMin) % this._defaults.stepMicrosec)), 10);
669669

670670
if (this.hour_slider) {
671-
this.control.options(this, this.hour_slider, 'hour', { min: this._defaults.hourMin, max: hourMax });
671+
this.control.options(this, this.hour_slider, 'hour', { min: this._defaults.hourMin, max: hourMax, step: this._defaults.stepHour });
672672
this.control.value(this, this.hour_slider, 'hour', this.hour - (this.hour % this._defaults.stepHour));
673673
}
674674
if (this.minute_slider) {
675-
this.control.options(this, this.minute_slider, 'minute', { min: this._defaults.minuteMin, max: minMax });
675+
this.control.options(this, this.minute_slider, 'minute', { min: this._defaults.minuteMin, max: minMax, step: this._defaults.stepMinute });
676676
this.control.value(this, this.minute_slider, 'minute', this.minute - (this.minute % this._defaults.stepMinute));
677677
}
678678
if (this.second_slider) {
679-
this.control.options(this, this.second_slider, 'second', { min: this._defaults.secondMin, max: secMax });
679+
this.control.options(this, this.second_slider, 'second', { min: this._defaults.secondMin, max: secMax, step: this._defaults.stepSecond });
680680
this.control.value(this, this.second_slider, 'second', this.second - (this.second % this._defaults.stepSecond));
681681
}
682682
if (this.millisec_slider) {
683-
this.control.options(this, this.millisec_slider, 'millisec', { min: this._defaults.millisecMin, max: millisecMax });
683+
this.control.options(this, this.millisec_slider, 'millisec', { min: this._defaults.millisecMin, max: millisecMax, step: this._defaults.stepMillisec });
684684
this.control.value(this, this.millisec_slider, 'millisec', this.millisec - (this.millisec % this._defaults.stepMillisec));
685685
}
686686
if (this.microsec_slider) {
687-
this.control.options(this, this.microsec_slider, 'microsec', { min: this._defaults.microsecMin, max: microsecMax });
687+
this.control.options(this, this.microsec_slider, 'microsec', { min: this._defaults.microsecMin, max: microsecMax, step: this._defaults.stepMicrosec });
688688
this.control.value(this, this.microsec_slider, 'microsec', this.microsec - (this.microsec % this._defaults.stepMicrosec));
689689
}
690690
}
@@ -1342,7 +1342,7 @@
13421342
var inst = this._getInst($(id)[0]),
13431343
tp_inst = this._get(inst, 'timepicker');
13441344

1345-
if (tp_inst) {
1345+
if (tp_inst && inst.settings.showTimepicker) {
13461346
tp_inst._limitMinMaxDateTime(inst, true);
13471347
inst.inline = inst.stay_open = true;
13481348
//This way the onSelect handler called from calendarpicker get the full dateTime
@@ -2140,6 +2140,6 @@
21402140
/*
21412141
* Keep up with the version
21422142
*/
2143-
$.timepicker.version = "1.4.3";
2143+
$.timepicker.version = "1.4.4";
21442144

21452145
})(jQuery);

dist/jquery-ui-timepicker-addon.min.css

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/jquery-ui-timepicker-addon.min.js

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/jquery-ui-timepicker-addon.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -674,23 +674,23 @@
674674
microsecMax = parseInt((this._defaults.microsecMax - ((this._defaults.microsecMax - this._defaults.microsecMin) % this._defaults.stepMicrosec)), 10);
675675

676676
if (this.hour_slider) {
677-
this.control.options(this, this.hour_slider, 'hour', { min: this._defaults.hourMin, max: hourMax });
677+
this.control.options(this, this.hour_slider, 'hour', { min: this._defaults.hourMin, max: hourMax, step: this._defaults.stepHour });
678678
this.control.value(this, this.hour_slider, 'hour', this.hour - (this.hour % this._defaults.stepHour));
679679
}
680680
if (this.minute_slider) {
681-
this.control.options(this, this.minute_slider, 'minute', { min: this._defaults.minuteMin, max: minMax });
681+
this.control.options(this, this.minute_slider, 'minute', { min: this._defaults.minuteMin, max: minMax, step: this._defaults.stepMinute });
682682
this.control.value(this, this.minute_slider, 'minute', this.minute - (this.minute % this._defaults.stepMinute));
683683
}
684684
if (this.second_slider) {
685-
this.control.options(this, this.second_slider, 'second', { min: this._defaults.secondMin, max: secMax });
685+
this.control.options(this, this.second_slider, 'second', { min: this._defaults.secondMin, max: secMax, step: this._defaults.stepSecond });
686686
this.control.value(this, this.second_slider, 'second', this.second - (this.second % this._defaults.stepSecond));
687687
}
688688
if (this.millisec_slider) {
689-
this.control.options(this, this.millisec_slider, 'millisec', { min: this._defaults.millisecMin, max: millisecMax });
689+
this.control.options(this, this.millisec_slider, 'millisec', { min: this._defaults.millisecMin, max: millisecMax, step: this._defaults.stepMillisec });
690690
this.control.value(this, this.millisec_slider, 'millisec', this.millisec - (this.millisec % this._defaults.stepMillisec));
691691
}
692692
if (this.microsec_slider) {
693-
this.control.options(this, this.microsec_slider, 'microsec', { min: this._defaults.microsecMin, max: microsecMax });
693+
this.control.options(this, this.microsec_slider, 'microsec', { min: this._defaults.microsecMin, max: microsecMax, step: this._defaults.stepMicrosec });
694694
this.control.value(this, this.microsec_slider, 'microsec', this.microsec - (this.microsec % this._defaults.stepMicrosec));
695695
}
696696
}

0 commit comments

Comments
 (0)