Merge pull request #79 from faceyspacey/entry-as-function

fix(index.js): Read entry when its a function

Author: ScriptedAlchemy

package.json

@@ -3,7 +3,7 @@
   "version": "0.0.0-placeholder",
   "author": "James Gillmore <james@faceyspacey.com>",
   "contributors": [
-    "Zack Jackson <zackary.l.jackson@gmail.com> (https://github.com/zackljackson)"
+    "Zack Jackson <zackary.l.jackson@gmail.com> (https://github.com/ScriptedAlchemy)"
   ],
   "description": "Extract CSS from chunks into stylesheets + HMR. Supports Webpack 4",
   "engines": {
@@ -47,7 +47,7 @@
     "travis": "npm run ci:coverage"
   },
   "peerDependencies": {
-    "webpack": "^4.4.0"
+    "webpack": "^4.8.3"
   },
   "dependencies": {
     "loader-utils": "^1.1.0",
@@ -85,7 +85,7 @@
     "pre-commit": "^1.2.2",
     "prettier": "^1.11.1",
     "standard-version": "^4.3.0",
-    "webpack": "^4.4.0",
+    "webpack": "4.8.3",
     "webpack-cli": "^2.0.13",
     "webpack-dev-server": "^3.1.1"
   },

src/index.js

@@ -24,7 +24,8 @@ const isHMR = (compiler) => {
     }
 
     if (compiler.options.entry) {
-      const entryString = JSON.stringify(compiler.options.entry);
+        const entry = typeof compiler.options.entry === 'function' ? compiler.options.entry() : compiler.options.entry;
+      const entryString = JSON.stringify(entry);
       return entryString.includes('hot') || entryString.includes('hmr');
     }
   }

yarn.lock

@@ -5138,7 +5138,7 @@ json-buffer@3.0.0:
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/json-buffer/-/json-buffer-3.0.0.tgz#5b1f397afc75d677bde8bcfc0e47e1f9a3d9a898"
 
-json-parse-better-errors@^1.0.1, json-parse-better-errors@^1.0.2:
+json-parse-better-errors@^1.0.1:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/json-parse-better-errors/-/json-parse-better-errors-1.0.2.tgz#bb867cfb3450e69107c131d1c514bab3dc8bcaa9"
 
@@ -8620,9 +8620,9 @@ webpack-sources@^1.0.1, webpack-sources@^1.1.0:
     source-list-map "^2.0.0"
     source-map "~0.6.1"
 
-webpack@^4.4.0:
-  version "4.9.1"
-  resolved "https://registry.yarnpkg.com/webpack/-/webpack-4.9.1.tgz#fa7bd738b17fd7f09f37da461b2f5c16c6565f34"
+webpack@4.8.3:
+  version "4.8.3"
+  resolved "https://registry.yarnpkg.com/webpack/-/webpack-4.8.3.tgz#957c8e80000f9e5cc03d775e78b472d8954f4eeb"
   dependencies:
     "@webassemblyjs/ast" "1.4.3"
     "@webassemblyjs/wasm-edit" "1.4.3"
@@ -8634,7 +8634,6 @@ webpack@^4.4.0:
     chrome-trace-event "^0.1.1"
     enhanced-resolve "^4.0.0"
     eslint-scope "^3.7.1"
-    json-parse-better-errors "^1.0.2"
     loader-runner "^2.3.0"
     loader-utils "^1.1.0"
     memory-fs "~0.4.1"