You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[css-view-transitions-1] Swap the order between setting the phase and calling the update callback (w3c#10826)
* [css-view-transitions-1] Swap the order between setting the phase and calling the update callback.
This fixes an issue where skipping the transition from within
thet update callback would call the update callback twice.
Closesw3c#10822
* Change order around
* Change order around
1. Otherwise, set |callbackPromise| to the result of [=/invoking=] |transition|'s [=ViewTransition/update callback=].
1608
1610
1609
-
1. If |transition|'s [=ViewTransition/phase=] is not "`done`", then set |transition|'s [=ViewTransition/phase=] to "`update-callback-called`".
1610
-
1611
1611
1. Let |fulfillSteps| be to following steps:
1612
1612
1. [=Resolve=] |transition|'s [=ViewTransition/update callback done promise=] with undefined.
1613
1613
@@ -1986,6 +1986,7 @@ Changes from <a href="https://www.w3.org/TR/2023/WD-css-view-transitions-1-20230
1986
1986
* Scope view transition names to matching tree context. See <a href="https://github.com/w3c/csswg-drafts/issues/10145">issue 10145</a>.
1987
1987
* Fix scoping to match name instead of element. See <a href="https://github.com/w3c/csswg-drafts/issues/10145">issue 10145</a>.
1988
1988
* Add a rendering characteristics note about out-of-viewport elements. See <a href="https://github.com/w3c/csswg-drafts/issues/8282">issue 8282</a>.
1989
+
* Swap the order of invoking the update callback and setting the phase. See <a href="https://github.com/w3c/csswg-drafts/issues/10822">issue 10822</a>.
1989
1990
1990
1991
<h3 id="changes-since-2022-05-25">
1991
1992
Changes from <a href="https://www.w3.org/TR/2023/WD-css-view-transitions-1-20230525/">2022-05-25 Working Draft</a>
0 commit comments