Skip to content

Commit 1e5c7c3

Browse files
garydgregorygarydgregory
committed
[CSV-291] Make CSVRecord#values() public.
1 parent 27d102c commit 1e5c7c3

4 files changed

Lines changed: 22 additions & 6 deletions

File tree

‎pom.xml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
<version>52</version>
2424
</parent>
2525
<artifactId>commons-csv</artifactId>
26-
<version>1.9.1-SNAPSHOT</version>
26+
<version>1.10.0-SNAPSHOT</version>
2727
<name>Apache Commons CSV</name>
2828
<url>https://commons.apache.org/proper/commons-csv/</url>
2929
<inceptionYear>2005</inceptionYear>
@@ -147,11 +147,11 @@
147147
</distributionManagement>
148148

149149
<properties>
150-
<commons.release.version>1.9.0</commons.release.version>
150+
<commons.release.version>1.10.0</commons.release.version>
151151
<commons.release.desc>(Java 8)</commons.release.desc>
152152
<!-- The RC version used in the staging repository URL. -->
153153
<commons.rc.version>RC1</commons.rc.version>
154-
<commons.bc.version>1.8</commons.bc.version>
154+
<commons.bc.version>1.9.0</commons.bc.version>
155155
<commons.componentid>csv</commons.componentid>
156156
<commons.module.name>org.apache.commons.csv</commons.module.name>
157157
<commons.jira.id>CSV</commons.jira.id>

‎src/changes/changes.xml‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,11 @@
3838
<title>Apache Commons CSV Release Notes</title>
3939
</properties>
4040
<body>
41-
<release version="1.9.1" date="2021-MM-DD" description="Feature and bug fix release (Java 8)">
42-
<action type="update" dev="ggregory" due-to="Arturo Bernal">Minor changes #172.</action>
41+
<release version="1.10.0" date="2021-MM-DD" description="Feature and bug fix release (Java 8)">
42+
<!-- FIX -->
43+
<action type="fix" dev="ggregory" due-to="Arturo Bernal">Minor changes #172.</action>
44+
<!-- ADD -->
45+
<action issue="CSV-291" type="add" dev="ggregory" due-to="Gary Gregory">Make CSVRecord#values() public.</action>
4346
<!-- UPDATE -->
4447
<action type="update" dev="ggregory" due-to="Dependabot">Bump checkstyle from 8.44 to 9.1 #180, #190, #194.</action>
4548
<action type="update" dev="ggregory" due-to="Dependabot">Bump junit-jupiter from 5.8.0-M1 to 5.8.1 #179, #186.</action>

‎src/main/java/org/apache/commons/csv/CSVRecord.java‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,13 @@ public String toString() {
329329
Arrays.toString(values) + "]";
330330
}
331331

332-
String[] values() {
332+
/**
333+
* Gets the values for this record. This is not a copy.
334+
*
335+
* @return the values for this record.
336+
* @since 1.10.0
337+
*/
338+
public String[] values() {
333339
return values;
334340
}
335341

‎src/site/resources/spotbugs/spotbugs-exclude-filter.xml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,11 @@
4848
<Bug pattern="EI_EXPOSE_REP"/>
4949
</Match>
5050

51+
<!-- [CSV-291] Make CSVRecord#values() public. -->
52+
<Match>
53+
<Class name="org.apache.commons.csv.CSVRecord" />
54+
<Method name="values" />
55+
<Bug pattern="EI_EXPOSE_REP"/>
56+
</Match>
57+
5158
</FindBugsFilter>

0 commit comments

Comments
 (0)