Position: added check for undefined value of offset. Fixed #7458 - ui.position offset property creates error when set to undefined

ashekthegreat · scottgonzalez · commit 19dcac2129a2 · 2011-06-09T21:05:33.000-04:00
diff --git a/ui/jquery.ui.position.js b/ui/jquery.ui.position.js
@@ -315,7 +315,7 @@ if ( $.uiBackCompat !== false ) {
 	(function( $ ) {
 		var _position = $.fn.position;
 		$.fn.position = function( options ) {
-			if ( !options || !( "offset" in options ) ) {
+			if ( !options || !options.offset ) {
 				return _position.call( this, options );
 			}
 			var offset = options.offset.split( " " ),

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,7 @@ if ( $.uiBackCompat !== false ) {`
`315`	`315`	`(function( $ ) {`
`316`	`316`	`var _position = $.fn.position;`
`317`	`317`	`$.fn.position = function( options ) {`
`318`		`- if ( !options \|\| !( "offset" in options ) ) {`
	`318`	`+ if ( !options \|\| !options.offset ) {`
`319`	`319`	`return _position.call( this, options );`
`320`	`320`	`}`
`321`	`321`	`var offset = options.offset.split( " " ),`