Skip to content

Commit 48f060a

Browse files
committed
Spinner: Ignore delta of 0 from triggered mousewheel event. Verified
that mousewheel scrolling actually works fine in IE6.
1 parent 9ac6bde commit 48f060a

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

tests/unit/spinner/spinner_core.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,14 +120,15 @@ test("mouse click on buttons", function() {
120120
});
121121

122122
test("mouse wheel on input", function() {
123-
expect(3);
123+
expect(4);
124+
stop();
124125

125126
var el = $("#spin").spinner();
127+
equal(el.val(), 0);
126128
el.trigger("mousewheel", 1);
127129
equal(el.val(), 1);
128130

129131
// mousewheel handler uses a timeout, need to accomodate that
130-
stop();
131132
setTimeout(function() {
132133
el.trigger("mousewheel", -1);
133134
equal(el.val(), 0);

ui/jquery.ui.spinner.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,13 @@ $.widget('ui.spinner', {
181181
}
182182
var self = this;
183183
this.element.bind("mousewheel.spinner", function(event, delta) {
184-
if (self.options.disabled) {
184+
if (self.options.disabled || !delta) {
185185
return;
186186
}
187187
if (!self.spinning && !self._start(event)) {
188188
return false;
189189
}
190+
$("<div>").text("delta: " + delta).appendTo(document.body)
190191
self._spin((delta > 0 ? 1 : -1) * self.options.step, event);
191192
clearTimeout(self.timeout);
192193
self.timeout = setTimeout(function() {

0 commit comments

Comments
 (0)