Skip to content

Commit 6c84531

Browse files
committed
Spinner: Fixed double firing of change event when setting the value option directly.
1 parent 6c9dac2 commit 6c84531

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

demos/spinner/default.html

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,19 @@
66
<link type="text/css" href="../../themes/base/jquery.ui.all.css" rel="stylesheet" />
77
<script type="text/javascript" src="../../jquery-1.6.2.js"></script>
88
<script type="text/javascript" src="../../external/jquery.mousewheel-3.0.4.js"></script>
9+
<script type="text/javascript" src="../../external/jquery.global.js"></script>
910
<script type="text/javascript" src="../../ui/jquery.ui.core.js"></script>
1011
<script type="text/javascript" src="../../ui/jquery.ui.widget.js"></script>
1112
<script type="text/javascript" src="../../ui/jquery.ui.button.js"></script>
1213
<script type="text/javascript" src="../../ui/jquery.ui.spinner.js"></script>
1314
<link type="text/css" href="../demos.css" rel="stylesheet" />
1415
<script type="text/javascript">
1516
$(function() {
16-
$("#spinner").spinner();
17+
$("#spinner").spinner({
18+
change: function() {
19+
console.log( "change" );
20+
}
21+
});
1722

1823
$("#disable").toggle(function() {
1924
$("#spinner").spinner("disable");

ui/jquery.ui.spinner.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ $.widget( "ui.spinner", {
287287

288288
_setOption: function( key, value ) {
289289
if ( key === "value" ) {
290-
return this._setOptionValue( value );
290+
return this._value( value );
291291
}
292292

293293
this._super( "_setOption", key, value );
@@ -303,14 +303,6 @@ $.widget( "ui.spinner", {
303303
}
304304
},
305305

306-
_setOptionValue: function( value ) {
307-
var previous = this.options.value;
308-
this._value( value );
309-
if ( previous !== this.options.value ) {
310-
this._trigger( "change" );
311-
}
312-
},
313-
314306
_setOptions: modifier(function( options ) {
315307
this._super( "_setOptions", options );
316308

@@ -342,6 +334,7 @@ $.widget( "ui.spinner", {
342334
_value: function( value ) {
343335
this.options.value = this._trimValue( this._parse(value) );
344336
this._format();
337+
this._aria();
345338
},
346339

347340
destroy: function() {

0 commit comments

Comments
 (0)