Grid Editing: Cleanup Editor and Grid-Editor options and callbacks

Author: jzaefferer

grid-editing/editor.js

@@ -10,6 +10,14 @@
 (function( $ ) {
 
 $.widget( "ui.editor", {
+	options: {
+		editor: null,
+		editorOptions: null,
+
+		// callbacks
+		cancel: null,
+		submit: null
+	},
 	_create: function() {
 		this.inner = this.element.wrapInner( "<div class='editor-wrapper'></div>" ).children();
 		this._bind({

grid-editing/grid-editor.js

@@ -16,26 +16,21 @@ $.widget( "ui.gridEditor", {
 		editorOptions: function( cell, grid ) {
 			return grid.options.columns[ cell[ 0 ].cellIndex ].editorOptions;
 		},
-		done: $.noop
+		items: "td"
 	},
 	_create: function() {
 		var grid = this.element.data("grid");
 		this._bind({
 			dblclick: function( event ) {
-				var that = this;
 				var target = $( event.target ).closest( this.options.items );
 				if ( target.length && !target.data( "editor" ) ) {
 					target.editor({
 						editor: this.options.editor( target, grid ),
 						editorOptions: this.options.editorOptions( target, grid ),
-						cancel: function( event, ui) {
-							that._trigger( "done", event, ui );
-						},
 						submit: function( event, ui) {
 							var object = target.closest("tr").data( "grid-item" ),
 								property = grid.options.columns[ target[ 0 ].cellIndex ].property;
 							$.observable( object ).property( property, ui.value );
-							that._trigger( "done", event, ui );
 						}
 					}).editor("start");
 				}