8000 Fix to issue #147, removes jumping and flickering occurring when selectmenu is opened by Ninkasi · Pull Request #154 · fnagel/jquery-ui · GitHub
Skip to content

Fix to issue #147, removes jumping and flickering occurring when selectmenu is opened #154

Closed
Ninkasi wants to merge 1 commit into
fnagel:selectmenufrom
Ninkasi:patch-1
Closed

Fix to issue #147, removes jumping and flickering occurring when selectmenu is opened #154
Ninkasi wants to merge 1 commit into
fnagel:selectmenufrom
Ninkasi:patch-1

Conversation

@Ninkasi
Copy link
Copy Markdown

@Ninkasi Ninkasi commented Aug 19, 2011

TESTED with IE9 (9.0.8112.16421), Chrome (13.0.782.112 m) AND FF (5.0.1)
Libraries used:
jquery-1.5.1
jquery.ui.1.8.9
jquery.ui.position.js
jquery.ui.selectmenu.js (2011.08.10)

@yaheys
Copy link
Copy Markdown

yaheys commented Aug 19, 2011

8000

Hi Ninkasi,

I have found a small bug in your code, when you re-click the main anchor the menu div is not closing. I think I have solve it. Just change the _toogle body to the following:

_toggle: function(event, retainFocus) {
    if ( this.listWrap.is('.' + this.widgetBaseClass + '-open') ) {
        this.close(event, retainFocus);
    } else {
        this.open(event);
    }
},

Thanks for your fix.

Yanko

@Ninkasi
FIX: removes jumping and flickering occurring when selectmenu is opened
02fb7d1 
TESTED with IE9 (9.0.8112.16421), Chrome (13.0.782.112 m) AND FF (5.0.1) 
Libraries: jquery-1.5.1, jquery.ui.1.8.9, jquery.ui.position.js and latest jquery.ui.selectmenu.js (2011.08.10)
@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Aug 20, 2011

I would need some informations to classify your comment:
In which browsers did you test this?

@Ninkasi & @yaheys
I assume you still experience the #147 issue. Can you give me a step by step tutorial how to reproduce the issue? I was not able to find any problems atm.
Perhaps you can provide a demo fiddle? See #61

@Ninkasi
Copy link
Copy Markdown
Author

Ninkasi commented Aug 20, 2011

Browsers i was using were:
IE9 (9.0.8112.16421
Chrome (13.0.782.112 m)
FF (5.0.1)

I was able to get rid of the jumping with this patch i posted but it only seems to fix this issue for the "dropdown" style menu.

@fnagel
Copy link
8000 Copy Markdown
Owner

fnagel commented Aug 20, 2011

As i commented within the code I would need step by step tutorial how to reproduce the issue or a test file / fiddle to reproduce the issue.

Problem does only occur in IE9 and latest stable Chrome, correct?

@yaheys
Copy link
Copy Markdown

yaheys commented Aug 20, 2011

Hi,

Browsers where I detected were IE7 and IE8. The fix from Ninkasi solve my
issue (the dropdown lost focus in the first click), but introduce the bug of
no closing de dropdown menu when you click in the main anchor when it is
open. I sent the code to him so it won't occur.

Yanko (@yaheys)

2011/8/20 fnagel <
reply@reply.github.com>

As i commented within the code I would need step by step tutorial how to
reproduce the issue or a test file / fiddle to reproduce the issue.

Problem does only occur in IE9 and latest stable Chrome, correct?

Reply to this email directly or view it on GitHub:
#154 (comment)

@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Aug 31, 2011

@yaheys
The problem is that Ninkasi code breaks the popup style. He is working on a new version.
Im still not able to reproduce the issue. Please post a demo fiddle and describe more accurate.

fnagel added a commit that referenced this pull request Sep 12, 2011
@fnagel
fixed: jumping in IE9, follow up to #147, see #154, thx to @Ninkasi
5472925
@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Sep 12, 2011

Please give feedback. Release 0.1.2 is already delayed.

@Ninkasi
Copy link
Copy Markdown
Author

Ninkasi commented Sep 14, 2011

You can find my latest patch here: https://github.com/Ninkasi/jquery-ui/blob/selectmenu/ui/jquery.ui.selectmenu.js

@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Oct 10, 2011

Sorry for the late response. I was pretty busy and my left spare time was used to create the new version of Selectmenu widget (see #140).

I was not able to reproduce the issue by using the posted demo ( http://www.students.oamk.fi/~jsaarija/selectmenu-test/ ). Ive tested in FF7, IE9 and latest stable Chrome.
What extactly needs to be done to reproduce the issue? Please with OS, Browser and a step-by-step tutorial.

@fnagel fnagel mentioned this pull request Oct 20, 2011
Closed
@fnagel
Copy link
Copy Markdown
Owner 8000

fnagel commented Oct 24, 2011

I feel cautiously optimistic Ive found a solution for this whole flickering/jumping/positioning issue. Finally. See and comment #147

@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Nov 2, 2011

Please test latest commit and give some feedback at #147

@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Nov 6, 2011

Please test version 1.2 or latest dev / commit and give feedback!

@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Nov 23, 2011

Please give some feedback!

1 similar comment
@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Dec 7, 2011

Please give some feedback!

@Ninkasi
Copy link
Copy Markdown
Author

Ninkasi commented Dec 8, 2011

Sorry for late response. Just got 1.2 version installed and tested. After bit of testing seems that it works like a charm. Thank you very much for your efforts!

@Ninkasi Ninkasi closed this Dec 8, 2011
@fnagel
Copy link
Copy Markdown
Owner

fnagel commented Dec 8, 2011

Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug needs_feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ninkasi @yaheys @fnagel