Skip to content

Commit f116cb3

Browse files
committed
Proper inheritance level for writing-mode, Fixes w3c#98
1 parent 6e270d2 commit f116cb3

File tree

4 files changed

+21
-18
lines changed

4 files changed

+21
-18
lines changed

org/w3c/css/properties/CSS3SVGProperties.properties

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ marker-end: org.w3c.css.properties.svg.CssMarkerEnd
1919
marker-mid: org.w3c.css.properties.svg.CssMarkerMid
2020
marker-start: org.w3c.css.properties.svg.CssMarkerStart
2121
kerning: org.w3c.css.properties.svg.CssKerning
22-
writing-mode: org.w3c.css.properties.svg.CssWritingMode
22+
# replaced with css3
23+
#writing-mode: org.w3c.css.properties.svg.CssWritingMode
2324
clip-path: org.w3c.css.properties.svg.CssClipPath
2425
clip-rule: org.w3c.css.properties.svg.CssClipRule
2526
mask: org.w3c.css.properties.svg.CssMask
@@ -378,6 +379,7 @@ ruby-position: org.w3c.css.properties.css3.CssRubyPosit
378379
ruby-align: org.w3c.css.properties.css3.CssRubyAlign
379380
ruby-overhang: org.w3c.css.properties.css3.CssRubyOverhang
380381
alignment-adjust: org.w3c.css.properties.css3.CssAlignmentAdjust
382+
writing-mode: org.w3c.css.properties.css3.CssWritingMode
381383
fit: org.w3c.css.properties.css3.CssFit
382384
handheld.background-clip: org.w3c.css.properties.css3.CssBackgroundClip
383385

org/w3c/css/properties/css/CssWritingMode.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66
package org.w3c.css.properties.css;
77

88
import org.w3c.css.parser.CssStyle;
9-
import org.w3c.css.properties.svg.SVGBasicStyle;
10-
import org.w3c.css.properties.svg.SVGTinyStyle;
9+
import org.w3c.css.properties.css3.Css3Style;
1110
import org.w3c.css.util.ApplContext;
1211
import org.w3c.css.util.InvalidParamException;
1312
import org.w3c.css.values.CssExpression;
1413
import org.w3c.css.values.CssValue;
1514

1615
/**
17-
* @since SVG
16+
* @since SVG OBSOLETED
17+
* @since CSS3
1818
*/
1919
public class CssWritingMode extends CssProperty {
2020

@@ -81,7 +81,7 @@ public String toString() {
8181
* @param style The CssStyle
8282
*/
8383
public void addToStyle(ApplContext ac, CssStyle style) {
84-
SVGBasicStyle s = (SVGBasicStyle) style;
84+
Css3Style s = (Css3Style) style;
8585
if (s.cssWritingMode != null) {
8686
style.addRedefinitionWarning(ac, this);
8787
}
@@ -108,9 +108,9 @@ public boolean equals(CssProperty property) {
108108
*/
109109
public CssProperty getPropertyInStyle(CssStyle style, boolean resolve) {
110110
if (resolve) {
111-
return ((SVGBasicStyle) style).getWritingMode();
111+
return ((Css3Style) style).getWritingMode();
112112
} else {
113-
return ((SVGBasicStyle) style).cssWritingMode;
113+
return ((Css3Style) style).cssWritingMode;
114114
}
115115
}
116116
}

org/w3c/css/properties/css3/Css3Style.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@
187187
import org.w3c.css.properties.css.CssVoiceStress;
188188
import org.w3c.css.properties.css.CssVoiceVolume;
189189
import org.w3c.css.properties.css.CssWillChange;
190+
import org.w3c.css.properties.css.CssWritingMode;
190191
import org.w3c.css.properties.css.CssWordBreak;
191192
import org.w3c.css.properties.css.counterstyle.CssAdditiveSymbols;
192193
import org.w3c.css.properties.css.counterstyle.CssFallback;
@@ -215,6 +216,8 @@ public class Css3Style extends ATSCStyle {
215216
public CssAdditiveSymbols counterStyleCssAdditiveSymbols;
216217
public CssNegative counterStyleCssNegative;
217218

219+
public CssWritingMode cssWritingMode;
220+
218221
public CssScrollSnapMarginBlockStart cssScrollSnapMarginBlockStart;
219222
public CssScrollSnapMarginBlockEnd cssScrollSnapMarginBlockEnd;
220223
public CssScrollSnapMarginInlineStart cssScrollSnapMarginInlineStart;
@@ -434,6 +437,15 @@ public class Css3Style extends ATSCStyle {
434437
public CssFloatOffset cssFloatOffset;
435438
public CssFloatDefer cssFloatDefer;
436439

440+
public CssWritingMode getWritingMode() {
441+
if (cssWritingMode == null) {
442+
cssWritingMode =
443+
(CssWritingMode) style.CascadingOrder(new CssWritingMode(),
444+
style, selector);
445+
}
446+
return cssWritingMode;
447+
}
448+
437449
public org.w3c.css.properties.css.counterstyle.CssSpeakAs getCounterStyleCssSpeakAs() {
438450
if (counterStyleCssSpeakAs == null) {
439451
counterStyleCssSpeakAs = (org.w3c.css.properties.css.counterstyle.CssSpeakAs) style.CascadingOrder(new org.w3c.css.properties.css.counterstyle.CssSpeakAs(), style, selector);

org/w3c/css/properties/svg/SVGBasicStyle.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import org.w3c.css.properties.css.CssStrokeOpacity;
2828
import org.w3c.css.properties.css.CssTextAnchor;
2929
import org.w3c.css.properties.css.CssTextRendering;
30-
import org.w3c.css.properties.css.CssWritingMode;
3130

3231
public class SVGBasicStyle extends SVGTinyStyle {
3332

@@ -40,7 +39,6 @@ public class SVGBasicStyle extends SVGTinyStyle {
4039
public CssFillOpacity cssFillOpacity;
4140
public CssStrokeOpacity cssStrokeOpacity;
4241
public CssKerning cssKerning;
43-
public CssWritingMode cssWritingMode;
4442
public CssClipPath cssClipPath;
4543
public CssClipRule cssClipRule;
4644
public CssMask cssMask;
@@ -133,15 +131,6 @@ public CssKerning getKerning() {
133131
return cssKerning;
134132
}
135133

136-
public CssWritingMode getWritingMode() {
137-
if (cssWritingMode == null) {
138-
cssWritingMode =
139-
(CssWritingMode) style.CascadingOrder(new CssWritingMode(),
140-
style, selector);
141-
}
142-
return cssWritingMode;
143-
}
144-
145134
public CssClipPath getClipPath() {
146135
if (cssClipPath == null) {
147136
cssClipPath =

0 commit comments

Comments
 (0)