Skip to content

Conversation

@matt-tingen
Copy link
Contributor

fix: crawl arrays and objects passed to callees

Description

Added cases for crawling ArrayExpression elements and ObjectExpression keys to each recursive parse function.

Fixes #99

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added unit tests for each rule covering class names in arrays and objects.

Test Configuration:

  • OS + version: macOS Catalina
  • NPM version: 8.1.0
  • Node version: 16.13.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@francoismassart
Copy link
Owner

@matt-tingen, it looks great!

Thank you, I'll:

  1. merge it
  2. publish it in a beta
  3. test it out on my current project
  4. publish it on latest

@francoismassart francoismassart merged commit 1a4971a into francoismassart:master Jan 18, 2022
@francoismassart
Copy link
Owner

3.3.0 published, thank you for your contribution 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] no-custom-classname false negative on arrays/objects passed to callee

2 participants