-
-
Notifications
You must be signed in to change notification settings - Fork 107
no-custom-classname plugin support
#132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-custom-classname plugin support
#132
Conversation
|
This is a draft because the classnames generated by plugins are not always present in I have to find a way to determine if a classname is generated by a plugin and which one... UPDATE: there are also the additional cases where the plugin introduces a new modifier. |
…lwindcss into fix/no-custom-classname-plugin-support # Conflicts: # package-lock.json # package.json
|
Maybe the WDYT ? |
|
If you are testing Take a moment to inspect the latest changelog: |
no-custom-classname plugin supportno-custom-classname plugin support
|
Tested on my main project with no issue but a lot of re-ordering 😅 |
|
I didn't formally create a GH issue, but this release solved some of the issues with classnames generated from plugins (#97)! Thanks for the work updating this! Updated to v3.6.0 in my team's project and it works well. Cheers! 🎉 |
Plugin support for
no-custom-classnameruleDescription
This PR changes the strategy used to determine if each classname belong or does not belong to Tailwind CSS.
This new strategy allow to detect classnames generated by plugins.
Fixes:
*-[color]/alphain the class name causes an error in the "tailwindcss/no-custom-classname" rule #130relative w-full overflow-hidden ${(className)}} not working. #131tailwindcss/no-custom-classnamewarning #145classnames-order: Mismatch withprettier-plugin-tailwindcsswithofficialSortingenabled #142border-spacing-class is not recognized #148Type of change
How Has This Been Tested?
Tested via unit tests visible in this PR
Checklist: