Skip to content

fix: Parsing spreads in object expressions #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoismassart merged 1 commit into from
Jun 24, 2023
Merged

fix: Parsing spreads in object expressions #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: Parsing spreads in object expressions
  • Loading branch information
@bezbac
bezbac committed Jun 3, 2023
commit 9a4bfeb7f8f5448029537c59c43bfe6e4d895e23
5 changes: 5 additions & 0 deletions lib/util/ast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,11 @@ function parseNodeRecursive(rootNode, childNode, cb, skipConditional = false, is
childNode.properties.forEach((prop) => {
const isUsedByClassNamesPlugin = rootNode.callee && rootNode.callee.name === 'classnames';

if (prop.type === 'SpreadElement') {
// Ignore spread elements
return;
}

if (prop.key.type === 'Identifier' && ignoredKeys.includes(prop.key.name)) {
// Ignore specific keys defined in settings
return;
Expand Down
8 changes: 8 additions & 0 deletions tests/lib/rules/no-custom-classname.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,14 @@ ruleTester.run("no-custom-classname", rule, {
},
],
},
{
code: `
const obj = { a: 12 };
<div className={{
...obj
}}>Spread inside classname object</div>
`,
},
],

invalid: [
Expand Down