Breaking: Replacing completed callback with proper event.

Author: digitalBush

demo/index.html

@@ -6,7 +6,10 @@
 <script type="text/javascript">
     $(function() {
         $.mask.definitions['~'] = "[+-]";
-        $("#date").mask("99/99/9999",{completed:function(){alert("completed!");}});
+        $("#date").mask("99/99/9999")
+            .on("completed.mask",function(){
+                alert("completed with value: "+this.value);
+            });
         $("#phone").mask("(999) 999-9999");
         $("#phoneExt").mask("(999) 999-9999? x99999");
         $("#iphone").mask("+33 999 999 999");

spec/Paste.Spec.js

@@ -1,8 +1,8 @@
-feature("Pasting", function() {	
+feature("Pasting", function() {
 	scenario('When pasting a value',function(){
 		var completed=false;
 		given("an input with a completed callback", function(){
-			input.mask("99",{completed:function(){completed=true;}});
+			input.mask("99").on("completed.mask",function(){completed=true;});
 		});
 
 		when("pasting",function(){
@@ -13,4 +13,4 @@ feature("Pasting", function() {
 			expect(completed).toBeTruthy();
 		});
 	});
-});
+});

src/jquery.maskedinput.js

@@ -73,7 +73,7 @@
                 completed: null
             }, settings);
 
-            //Hardcoded as fixed for now. 
+            //Hardcoded as fixed for now.
             var mask=new $.mask.masks.fixed(format, settings);
 
             return this.trigger("unmask").each(function() {
@@ -137,8 +137,9 @@
 
                         elm.value = result.value;
                         setCaret(elm, result.pos);
-                        if(result.isComplete && settings.completed)
-                            settings.completed.call(input); //TODO: Raise event instead.
+                        if(result.isComplete)
+                            input.trigger("completed.mask");
+
                         e.preventDefault();
 
                         // if(android){
@@ -178,8 +179,8 @@
                         var result = mask.apply(elm.value, pos.end);
                         elm.value = result.value;
                         setCaret(elm, result.pos);
-                        if(result.isComplete && settings.completed)
-                            settings.completed.call(input); //TODO: Raise event instead.
+                        if(result.isComplete)
+                            input.trigger("completed.mask");
                     }, 0);
                 }
                 input.data($.mask.dataName,mask);