optimise check version logic

Author: sdoomz

package.json

@@ -39,6 +39,7 @@
     "husky": "^0.11.9",
     "jsdom": "^9.8.3",
     "mocha": "^3.1.2",
+    "proxyquire": "^1.7.10",
     "react": "^15.4.0-rc.4",
     "react-addons-shallow-compare": "^15.4.0-rc.4",
     "react-addons-test-utils": "^15.4.0-rc.4",

src/extendReactClass.js

@@ -3,7 +3,7 @@
 import _ from 'lodash';
 import hoistNonReactStatics from 'hoist-non-react-statics';
 import linkClass from './linkClass';
-import renderNothing from './renderNothing';
+import nothing from './renderNothing';
 
 /**
  * @param {ReactClass} Component
@@ -49,7 +49,7 @@ export default (Component: Object, defaultStyles: Object, options: Object) => {
         return linkClass(renderResult, styles, options);
       }
 
-      return renderNothing();
+      return nothing;
     }
   };
 

src/renderNothing.js

@@ -1,7 +1,6 @@
 import React from 'react';
 
-export default function () {
-  const major = React.version.split('.')[0];
+const major = React.version.split('.')[0];
+const nothing = parseInt(major, 10) < 15 ? React.createElement('noscript') : null;
 
-  return parseInt(major, 10) < 15 ? React.createElement('noscript') : null;
-}
+export default nothing;

src/wrapStatelessFunction.js

@@ -2,7 +2,7 @@
 
 import _ from 'lodash';
 import linkClass from './linkClass';
-import renderNothing from './renderNothing';
+import nothing from './renderNothing';
 
 /**
  * @see https://facebook.github.io/react/blog/2015/09/10/react-v0.14-rc1.html#stateless-function-components
@@ -39,7 +39,7 @@ export default (Component: Function, defaultStyles: Object, options: Object): Fu
       return linkClass(renderResult, styles, options);
     }
 
-    return renderNothing();
+    return nothing;
   };
 
   _.assign(WrappedComponent, Component);

tests/renderNothing.js

@@ -3,21 +3,20 @@
 import {
     expect
 } from 'chai';
-import React from 'react';
-import renderNothing from '../src/renderNothing';
-
-const version = React.version;
+import proxyquire from 'proxyquire';
 
 describe('renderNothing', () => {
   context('renderNothing should return different node types for various React versions', () => {
-    it('should return noscript tag for React v14.0.0', () => {
-      React.version = '14.0.0';
-      expect(renderNothing().type).to.equal('noscript');
-      React.version = version;
+    it('should return null for React v15.0.0 or later', () => {
+      const renderNothing = proxyquire('../src/renderNothing', {react: {version: '15.0.0'}});
+
+      expect(renderNothing).to.equal(null);
     });
 
-    it('should return null for current version', () => {
-      expect(renderNothing()).to.equal(null);
+    it('should return noscript tag for React v14.0.0 or earlier', () => {
+      const renderNothing = proxyquire('../src/renderNothing', {react: {version: '14.0.0'}});
+
+      expect(renderNothing.type).to.equal('noscript');
     });
   });
 });