Use isEmpty().

garydgregory · garydgregory · commit 353771a4bfc5 · 2021-01-17T09:27:33.000-05:00
diff --git a/src/main/java/org/apache/commons/cli/HelpFormatter.java b/src/main/java/org/apache/commons/cli/HelpFormatter.java
@@ -693,7 +693,7 @@ private void appendOption(final StringBuffer buff, final Option option, final bo
         }
 
         // if the Option has a value and a non blank argname
-        if (option.hasArg() && (option.getArgName() == null || option.getArgName().length() != 0))
+        if (option.hasArg() && (option.getArgName() == null || !option.getArgName().isEmpty()))
         {
             buff.append(option.getOpt() == null ? longOptSeparator : " ");
             buff.append("<").append(option.getArgName() != null ? option.getArgName() : getArgName()).append(">");

Original file line number	Diff line number	Diff line change
`@@ -693,7 +693,7 @@ private void appendOption(final StringBuffer buff, final Option option, final bo`
`693`	`693`	`}`
`694`	`694`
`695`	`695`	`// if the Option has a value and a non blank argname`
`696`		`- if (option.hasArg() && (option.getArgName() == null \|\| option.getArgName().length() != 0))`
	`696`	`+ if (option.hasArg() && (option.getArgName() == null \|\| !option.getArgName().isEmpty()))`
`697`	`697`	`{`
`698`	`698`	`buff.append(option.getOpt() == null ? longOptSeparator : " ");`
`699`	`699`	`buff.append("<").append(option.getArgName() != null ? option.getArgName() : getArgName()).append(">");`