Use try-with-resources.

- Fix Javadoc warning.
- Checkstyle.

Author: garydgregory

src/main/java/org/apache/commons/cli/Option.java

@@ -412,7 +412,7 @@ private void add(final String value) {
      * @param value the value to add
      * @return always throws an {@link UnsupportedOperationException}
      * @throws UnsupportedOperationException always
-     * @deprecated
+     * @deprecated Unused.
      */
     @Deprecated
     public boolean addValue(final String value) {

src/test/java/org/apache/commons/cli/HelpFormatterTest.java

@@ -458,7 +458,7 @@ public void testPrintUsage() {
         opts.addOption(optionC);
         final HelpFormatter helpFormatter = new HelpFormatter();
         final ByteArrayOutputStream bytesOut = new ByteArrayOutputStream();
-        try (final PrintWriter printWriter = new PrintWriter(bytesOut)) {
+        try (PrintWriter printWriter = new PrintWriter(bytesOut)) {
             helpFormatter.printUsage(printWriter, 80, "app", opts);
         }
         assertEquals("usage: app [-a] [-b] [-c]" + EOL, bytesOut.toString());

src/test/java/org/apache/commons/cli/TypeHandlerTest.java

@@ -55,9 +55,10 @@ public void testCreateValueDate() throws Exception {
 
     @Test
     public void testCreateValueExistingFile() throws Exception {
-        final FileInputStream result = TypeHandler.createValue("src/test/resources/org/apache/commons/cli/existing-readable.file",
-            PatternOptionBuilder.EXISTING_FILE_VALUE);
-        assertNotNull(result);
+        try (FileInputStream result = TypeHandler.createValue("src/test/resources/org/apache/commons/cli/existing-readable.file",
+            PatternOptionBuilder.EXISTING_FILE_VALUE)) {
+            assertNotNull(result);
+        }
     }
 
     @Test(expected = ParseException.class)