Use final.

Author: garydgregory

src/main/java/org/apache/commons/cli/DefaultParser.java

@@ -55,7 +55,7 @@ public class DefaultParser implements CommandLineParser
     protected List expectedOpts;
 
     /** Flag indicating if partial matching of long options is supported. */
-    private  boolean allowPartialMatching;
+    private final  boolean allowPartialMatching;
 
     /**
      * Creates a new DefaultParser instance with partial matching enabled.
@@ -718,10 +718,10 @@ private List<String> getMatchingLongOptions(final String token)
         }
         else
         {
-            List<String> matches = new ArrayList<>(1);
+            final List<String> matches = new ArrayList<>(1);
             if (options.hasLongOption(token))
             {
-                Option option = options.getOption(token);
+                final Option option = options.getOption(token);
                 matches.add(option.getLongOpt());
             }
 

src/main/java/org/apache/commons/cli/TypeHandler.java

@@ -231,7 +231,7 @@ public static File createFile(final String str)
      * @return The file input stream represented by <code>str</code>.
      * @throws ParseException if the file is not exist or not readable
      */
-    public static FileInputStream openFile(String str) throws ParseException
+    public static FileInputStream openFile(final String str) throws ParseException
     {
         try
         {

src/test/java/org/apache/commons/cli/DisablePartialMatchingTest.java

@@ -27,15 +27,15 @@ public class DisablePartialMatchingTest
     @Test
     public void testDisablePartialMatching() throws Exception
     {
-        CommandLineParser parser = new DefaultParser(false);
+        final CommandLineParser parser = new DefaultParser(false);
 
         final Options options = new Options();
 
         options.addOption(new Option("d", "debug", false, "Turn on debug."));
         options.addOption(new Option("e", "extract", false, "Turn on extract."));
         options.addOption(new Option("o", "option", true, "Turn on option with argument."));
 
-        CommandLine line = parser.parse(options, new String[]{"-de", "--option=foobar"});
+        final CommandLine line = parser.parse(options, new String[]{"-de", "--option=foobar"});
 
         assertTrue("There should be an option debug in any case...", line.hasOption("debug"));
         assertTrue("There should be an extract option because partial matching is off", line.hasOption("extract"));

src/test/java/org/apache/commons/cli/TypeHandlerTest.java

@@ -55,7 +55,7 @@ public void testCreateValueObject_notInstantiableClass()
     public void testCreateValueObject_InstantiableClass()
         throws Exception
     {
-        Object result = TypeHandler.createValue(Instantiable.class.getName(), PatternOptionBuilder.OBJECT_VALUE);
+        final Object result = TypeHandler.createValue(Instantiable.class.getName(), PatternOptionBuilder.OBJECT_VALUE);
         assertTrue(result instanceof Instantiable);
     }
 
@@ -98,23 +98,23 @@ public void testCreateValueClass_notFound()
     public void testCreateValueClass()
         throws Exception
     {
-        Object clazz = TypeHandler.createValue(Instantiable.class.getName(), PatternOptionBuilder.CLASS_VALUE);
+        final Object clazz = TypeHandler.createValue(Instantiable.class.getName(), PatternOptionBuilder.CLASS_VALUE);
         assertEquals(Instantiable.class, clazz);
     }
 
     @Test
     public void testCreateValueFile()
             throws Exception
     {
-        File result = TypeHandler.createValue("some-file.txt", PatternOptionBuilder.FILE_VALUE);
+        final File result = TypeHandler.createValue("some-file.txt", PatternOptionBuilder.FILE_VALUE);
         assertEquals("some-file.txt", result.getName());
     }
 
     @Test
     public void testCreateValueExistingFile()
             throws Exception
     {
-        FileInputStream result = TypeHandler.createValue("src/test/resources/org/apache/commons/cli/existing-readable.file", PatternOptionBuilder.EXISTING_FILE_VALUE);
+        final FileInputStream result = TypeHandler.createValue("src/test/resources/org/apache/commons/cli/existing-readable.file", PatternOptionBuilder.EXISTING_FILE_VALUE);
         assertNotNull(result);
     }
 
@@ -136,8 +136,8 @@ public void testCreateValueFiles()
     public void testCreateValueURL()
             throws Exception
     {
-        String urlString = "https://commons.apache.org";
-        URL result = TypeHandler.createValue(urlString, PatternOptionBuilder.URL_VALUE);
+        final String urlString = "https://commons.apache.org";
+        final URL result = TypeHandler.createValue(urlString, PatternOptionBuilder.URL_VALUE);
         assertEquals(urlString, result.toString());
     }