ExceptionHandler

Author: gerardpuigl

src/main/java/com/itacademy/CrudEmpleats/controller/ControllerEmployees.java

@@ -6,30 +6,18 @@
 import javax.servlet.http.HttpServletResponse;
 
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.http.HttpStatus;
 import org.springframework.web.bind.annotation.*;
 
 import com.itacademy.CrudEmpleats.domain.Employee;
 import com.itacademy.CrudEmpleats.persistence.EmployeeRepository;
 
 @RestController
 public class ControllerEmployees {
-
 	/*
-	 * Crearem un programa de gestió d'empleats molt senzill on depenent de la feina
-	 * de l'empleat se li assignarà un salari automàticament
-	 * 
-	 * El domini ha de tindre el CRUD al complet (Create, Read, Update, Delete),
-	 * utilitzant els verbs HTTP associats.
-	 * 
-	 * Crea una petició HTTP especial que busqui empleats per feina, a més de totes
-	 * les que creen, llegeixen, actualitzen o esborren elements de tipus empleat
-	 * 
-	 * Has de tindre en compte les bones pràctiques de disseny de les API: utilitzi
-	 * correctament els codis d'error i les respostes en cas d'invocacions
-	 * incorrectes
-	 * 
+	 * Controlador d'operacions CRUD
 	 */
-
+	
 	@Autowired
 	private EmployeeRepository repositori;
 
@@ -42,6 +30,7 @@ void start(HttpServletResponse reponse) throws IOException {
 
 	// Crear nou empleat
 	@PostMapping( "/Empleat")
+	@ResponseStatus(HttpStatus.CREATED)  // 201
 	public Employee addEmployee(@RequestBody Employee employee) {
 		repositori.addEmployee(employee);
 		return employee;
@@ -61,18 +50,17 @@ public Employee getFirstEmployee(@PathVariable("id") int id) {
 
 	// Actualitzar Empleat
 	@PutMapping("/Empleat/{id}")
+	@ResponseStatus(HttpStatus.ACCEPTED)  // 202
 	public Employee updateEmployee(@RequestBody Employee employee, @PathVariable("id") int id) {
 		repositori.updateEmployee(employee,id);
 		return repositori.getEmployeeById(id);
 	}
 
 	// Eliminar Empleat
 	@DeleteMapping("/Empleat/{id}")
-	public String deleteEmployee( @PathVariable("id") int id) {
-		repositori.deleteEmployee(id);
-		if(repositori.getEmployeeById(id)==null) {
+	@ResponseStatus(HttpStatus.ACCEPTED)  // 202
+	public String deleteEmployee(@PathVariable("id") int id) {
+			repositori.deleteEmployee(id);
 			return "Empleat eliminat correctament.";
-		}
-			return "L'emplat no s'ha pogut eliminar.";
 	}
 }

src/main/java/com/itacademy/CrudEmpleats/controller/ControllerExceptions.java

@@ -0,0 +1,41 @@
+package com.itacademy.CrudEmpleats.controller;
+
+import org.springframework.http.HttpStatus;
+
+import org.springframework.web.bind.annotation.ExceptionHandler;
+import org.springframework.web.bind.annotation.ResponseStatus;
+import org.springframework.web.bind.annotation.RestControllerAdvice;
+import org.springframework.web.method.annotation.MethodArgumentTypeMismatchException;
+
+import com.itacademy.CrudEmpleats.exceptions.IdNotFound;
+
+@RestControllerAdvice
+public class ControllerExceptions {
+
+	//Excepció si no s'indrodueix un integer al id de la petició.	
+	@ExceptionHandler(MethodArgumentTypeMismatchException.class)
+	@ResponseStatus(HttpStatus.PRECONDITION_FAILED)  // 412
+	public String misMatchException(MethodArgumentTypeMismatchException e) {
+		return "<h2>Error!</h2>"
+				+ "El paràmetre <strong>" + e.getName()+" = " + e.getValue() + "</strong>"
+				+ " ha de ser del tipus <strong>"+ e.getRequiredType() + "</strong>.";
+	}
+
+	//Excepció is no es troba l'element demanat.
+	@ExceptionHandler(IdNotFound.class)
+	@ResponseStatus(HttpStatus.NOT_FOUND)  // 404
+	public String noSuchElementException(IdNotFound e) {
+		return "<h2>Error!</h2>"
+				+ "No s'ha trobat cap empleat amb el ID: " + e.getId();
+	}
+
+		
+	//Filtre per errors no controlats amb informació per millorar l'aplicació.
+	@ExceptionHandler(Exception.class)
+	@ResponseStatus(HttpStatus.CONFLICT)  // 409
+	public String exceptionHandeler(Exception e) {
+		return "<h2>Error!</h2>"
+				+ "Tipo: " + e.getClass() + "<br>"
+				+ "Mensaje Error: " + e.getMessage();
+	}
+}

src/main/java/com/itacademy/CrudEmpleats/domain/Employee.java

@@ -2,24 +2,14 @@
 
 public class Employee {
 
-	/*
-	 * D'un treballador identifiquem el nom i la seva feina, estaria bé tenir un
-	 * identificador únic per aquest treballador.
-	 * Depenent de la feina s'assignarà un
-	 * salari a l'empleat un cop es crea.
-	 * 
-	 */
-	
-	private static int idCount=0;
 	private int id;
 	private String name;
 	private String job;
 	private double salary ;
 
-
-	
-	public Employee(String name, String job) {
-		this.id=idCount++;
+	//salari i cárreg en funció de la calsse Jobs Enum.
+	public Employee(int id,String name, String job) {
+		this.id=id;
 		this.name = name;
 		this.job = Jobs.valueOf(job).getName();
 		this.salary = Jobs.valueOf(job).getSalary();
@@ -48,7 +38,5 @@ public void setJob(String job) {
 	public double getSalary() {
 		return salary;
 	}
-	
-	
-	
+
 }

src/main/java/com/itacademy/CrudEmpleats/domain/Jobs.java

@@ -2,10 +2,7 @@
 
 public enum Jobs {
 
-	/*
-	 * Les feines són fixes, és a dir ja estan definits en un ENUMERABLE.
-	 * 
-	 */
+	//Enum que defineix nom del carreg i sou.
 
 	Director_Projectes("Director de projectes",50000),
 	Programador_Senior("Programador Senior",35000),

src/main/java/com/itacademy/CrudEmpleats/exceptions/IdNotFound.java

@@ -0,0 +1,14 @@
+package com.itacademy.CrudEmpleats.exceptions;
+
+public class IdNotFound extends RuntimeException {
+
+	private int id;
+	
+	public IdNotFound(int id) {
+		this.id=id;
+	}
+
+	public int getId() {
+		return id;
+	}
+}

src/main/java/com/itacademy/CrudEmpleats/persistence/EmployeeRepository.java

@@ -5,22 +5,31 @@
 import org.springframework.stereotype.Service;
 
 import com.itacademy.CrudEmpleats.domain.Employee;
+import com.itacademy.CrudEmpleats.exceptions.IdNotFound;
 
 @Service
-public class EmployeeRepository {
+public class EmployeeRepository implements IEmployeeRepository{
 
-	/*
-	 * Els objectes seran persistits únicament en memòria
-	 * 
-	 */
+	// Els objectes persistents únicament en memòria
 
+	private static int idcount=0;
+	/*
 	private List<Employee> repository = new ArrayList<>(
 			Arrays.asList(
 					new Employee("Joan", "Director_Projectes"),
 					new Employee("Gerard", "Programador_Junior"),
 					new Employee("Maria", "Administrativa")
 					)
 			);
+	*/
+	private List<Employee> repository = new ArrayList<>(
+			Arrays.asList(
+					new Employee(idcount++,"Joan", "Director_Projectes"),
+					new Employee(idcount++,"Gerard", "Programador_Junior"),
+					new Employee(idcount++,"Maria", "Administrativa")
+					)
+			);
+	
 
 	public List<Employee> getAllEmployees() {
 		return repository;
@@ -30,26 +39,23 @@ public Employee getEmployeeById(int id){
 		try {
 			return repository.stream().filter(employee -> employee.getId()==id).findFirst().get();
 		} catch (Exception e) {
-			return null;
+			throw new IdNotFound(id);
 		}
-
 	}
 
 	public void addEmployee(Employee employee) {
+		employee.setId(idcount++);
 		repository.add(employee);
-		
 	}
 
 	public void updateEmployee(Employee employee, int id) {
-		for(Employee e : repository) {
-			if(e.getId()==id) {
-				repository.set(repository.indexOf(e),employee);
-			}
-		}
+		Employee existingEmployee = getEmployeeById(id);
+		employee.setId(id); //garantitzar que el nou objecte tingui el mateix id que l'antic.
+		repository.set(repository.indexOf(existingEmployee),employee);
 	}
 
 	public void deleteEmployee(int id) {
-		repository.removeIf(empleat -> empleat.getId()==id);		
+		repository.remove(getEmployeeById(id));
 	}
 
 }

src/main/java/com/itacademy/CrudEmpleats/persistence/IEmployeeRepository.java

@@ -0,0 +1,19 @@
+package com.itacademy.CrudEmpleats.persistence;
+
+import java.util.List;
+
+import com.itacademy.CrudEmpleats.domain.Employee;
+
+public interface IEmployeeRepository {
+	
+	public List<Employee> getAllEmployees();
+	
+	public Employee getEmployeeById(int id);
+
+	public void addEmployee(Employee employee);
+
+	public void updateEmployee(Employee employee, int id);
+
+	public void deleteEmployee(int id);
+
+}