Nivell 3 Corrections

Author: gerardpuigl

src/main/java/com/itacademy/CrudEmpleats/controller/ControllerWeb.java

@@ -2,6 +2,8 @@
 
 public class IdNotFound extends RuntimeException {
 
+	private static final long serialVersionUID = 1L;
+	
 	private int id;
 
 	public IdNotFound(int id) {

src/main/java/com/itacademy/CrudEmpleats/exceptions/IdNotFound.java

@@ -554,6 +554,7 @@ pre code {
 
 .table thead th {
   vertical-align: bottom;
+  background-color: white;
   border-bottom: 2px solid #dee2e6;
 }
 
@@ -588,9 +589,13 @@ pre code {
 }
 
 .table-striped tbody tr:nth-of-type(odd) {
-  background-color: rgba(0, 0, 0, 0.05);
+  background-color: rgba(0, 0, 0, 0.10);
 }
 
+.table-striped tbody tr:nth-of-type(even) {
+  background-color: rgb(255, 255, 255);
+
+}
 .table-hover tbody tr:hover {
   color: #212529;
   background-color: rgba(0, 0, 0, 0.075);

src/main/resources/static/custom_bootstrap.min.css

@@ -1,7 +1,7 @@
  body::after {
     content: "";
     background: url(background.jpeg);
-    opacity: 0.6;
+    opacity: 0.5;
     top: 0;
     left: 0;
     bottom: 0;

src/main/resources/static/index.css

@@ -2,11 +2,10 @@ $(document).ready(function () {
 	updateTable();
 });
 
-var table=$('#employeeTable').DataTable({
-    columnDefs: [
-        {targets: '_all',classname: 'dt-center' }
-      ]
-  });
+var table = $('#employeeTable').DataTable({
+	columnDefs: [
+		{ targets: '_all', className: 'text-center' }]
+});
 
 //Read employee List & Update the table
 function updateTable() {
@@ -16,19 +15,19 @@ function updateTable() {
 			table.row.add(createRow(employee)).draw();
 		});
 	});
-};
+}
 
 //create Row for DataTables Format
-function createRow(employee){
+function createRow(employee) {
 	return [
 		employee.id,
 		employee.name,
 		employee.job,
 		employee.salary,
-	   "<button type='button' class='btn btn-light' data-toggle='modal' data-target='#modal' onclick='editEmployee(" + employee.id + ")'>Modificar</button>" +
-	   "<button type='button' class='btn btn-danger' onclick='deleteEmployee(" + employee.id + ")'>Eliminar</button>" 
-	   ];
-};
+		"<button type='button' class='btn btn-light' data-toggle='modal' data-target='#modal' onclick='editEmployee(" + employee.id + ")'>Modificar</button>" +
+		"<button type='button' class='btn btn-danger' onclick='deleteEmployee(" + employee.id + ")'>Eliminar</button>"
+	];
+}
 
 //Create & update
 function sendEmployee() {
@@ -43,7 +42,7 @@ function sendEmployee() {
 				"job": $('#job').val()
 			}),
 			success: function (data, textStatus, jQxhr) {
-				table.row.add(createRow(data)).order( [ 0, 'asc' ] ).page('last').draw(false);
+				table.row.add(createRow(data)).order([0, 'asc']).page('last').draw(false);
 			},
 			error: function (xhr, textStatus, errorThrown) {
 				console.log(textStatus);
@@ -72,7 +71,7 @@ function sendEmployee() {
 	$('#EmployeeForm').trigger('reset');
 	$('#action').val('Afegir');
 	$('#formType').html('Afegir nou');
-};
+}
 
 //Delete employee
 function deleteEmployee(id) {
@@ -91,27 +90,27 @@ function deleteEmployee(id) {
 			}
 		},
 		callback: function (result) {
-			if (result == true) {
+			if (result === true) {
 				$.ajax({
 					type: "DELETE",
 					url: "/EmployeeList/" + id,
 					success: function (data, textStatus, jQxhr) {
 						var indexes = table
-						.rows()
-						.indexes()
-						.filter( function ( value, index ) {
-						  return id === table.row(value).data()[0];
-						} );
-					   table.rows(indexes).remove().draw(false);
+							.rows()
+							.indexes()
+							.filter(function (value, index) {
+								return id === table.row(value).data()[0];
+							});
+						table.rows(indexes).remove().draw(false);
 					},
 					error: function (xhr, textStatus, errorThrown) {
 						console.log(textStatus);
 					}
 				});
 			}
 		}
-	})
-};
+	});
+}
 
 //Read one employee info and put in the modifier form.
 function editEmployee(id) {
@@ -122,7 +121,7 @@ function editEmployee(id) {
 	});
 	$('#action').val('Actualitzar');
 	$('#formType').html('Actualizar');
-};
+}
 
 //Set Form in New Employee Mode
 function newEmployee() {
@@ -146,4 +145,4 @@ function getJobCode(job) {
 	} else {
 		return "Default";
 	}
-}
+}

src/main/resources/static/index.js

@@ -59,7 +59,15 @@ <h6>Exercici realitzat utilitzant: Spring Api Rest, Javascript, jquery i Bootstr
 								<th style="width:22%">Accions</th>
 							</tr>
 						</thead>
-						<tbody></tbody>
+						<tbody>								
+							<td>id</td>
+							<td>nom</td>
+							<td>carreg</td>
+							<td>sou</td>
+							<td><button type="button" class="btn btn-primary add" data-toggle="modal" data-target="#modal" onclick="newEmployee();">
+								Nou Empleat</button></td>
+
+						</tbody>
 					</table>
 				</div>
 			</div>