Skip to content
This repository was archived by the owner on Jun 3, 2026. It is now read-only.

Commit 0e8084a

Browse files
committed
Rename getRecord() to nextRecord()
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/csv/trunk@1397900 13f79535-47bb-0310-9956-ffa450edef68
1 parent 3b938ba commit 0e8084a

2 files changed

Lines changed: 19 additions & 19 deletions

File tree

src/main/java/org/apache/commons/csv/CSVParser.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public long getRecordNumber() {
161161
* @throws IOException
162162
* on parse error or input read-failure
163163
*/
164-
CSVRecord getRecord() throws IOException {
164+
CSVRecord nextRecord() throws IOException {
165165
CSVRecord result = new CSVRecord(null, headerMap, null, recordNumber + 1);
166166
record.clear();
167167
StringBuilder sb = null;
@@ -217,7 +217,7 @@ CSVRecord getRecord() throws IOException {
217217
public List<CSVRecord> getRecords() throws IOException {
218218
final List<CSVRecord> records = new ArrayList<CSVRecord>();
219219
CSVRecord rec;
220-
while ((rec = getRecord()) != null) {
220+
while ((rec = nextRecord()) != null) {
221221
records.add(rec);
222222
}
223223
return records;
@@ -234,7 +234,7 @@ private Map<String, Integer> initializeHeader(final CSVFormat format) throws IOE
234234
String[] header = null;
235235
if (format.getHeader().length == 0) {
236236
// read the header from the first line of the file
237-
final CSVRecord rec = getRecord();
237+
final CSVRecord rec = nextRecord();
238238
if (rec != null) {
239239
header = rec.values();
240240
}
@@ -262,7 +262,7 @@ public Iterator<CSVRecord> iterator() {
262262

263263
private CSVRecord getNextRecord() {
264264
try {
265-
return getRecord();
265+
return nextRecord();
266266
} catch (final IOException e) {
267267
throw new RuntimeException(e);
268268
}

src/test/java/org/apache/commons/csv/CSVParserTest.java

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,10 @@ public class CSVParserTest {
7070
public void testGetLine() throws IOException {
7171
final CSVParser parser = new CSVParser(new StringReader(CSVINPUT), CSVFormat.DEFAULT.withIgnoreSurroundingSpaces(true));
7272
for (final String[] re : RESULT) {
73-
assertArrayEquals(re, parser.getRecord().values());
73+
assertArrayEquals(re, parser.nextRecord().values());
7474
}
7575

76-
assertNull(parser.getRecord());
76+
assertNull(parser.nextRecord());
7777
}
7878

7979
@Test
@@ -232,7 +232,7 @@ public void testEmptyLineBehaviourCSV() throws Exception {
232232
@Test
233233
public void testEmptyFile() throws Exception {
234234
final CSVParser parser = new CSVParser("", CSVFormat.DEFAULT);
235-
assertNull(parser.getRecord());
235+
assertNull(parser.nextRecord());
236236
}
237237

238238
@Test
@@ -612,19 +612,19 @@ public void testGetRecordWithMultiiLineValues() throws Exception {
612612
CSVRecord record;
613613
assertEquals(0, parser.getRecordNumber());
614614
assertEquals(0, parser.getLineNumber());
615-
assertNotNull(record = parser.getRecord());
615+
assertNotNull(record = parser.nextRecord());
616616
assertEquals(3, parser.getLineNumber());
617617
assertEquals(1, record.getRecordNumber());
618618
assertEquals(1, parser.getRecordNumber());
619-
assertNotNull(record = parser.getRecord());
619+
assertNotNull(record = parser.nextRecord());
620620
assertEquals(6, parser.getLineNumber());
621621
assertEquals(2, record.getRecordNumber());
622622
assertEquals(2, parser.getRecordNumber());
623-
assertNotNull(record = parser.getRecord());
623+
assertNotNull(record = parser.nextRecord());
624624
assertEquals(8, parser.getLineNumber());
625625
assertEquals(3, record.getRecordNumber());
626626
assertEquals(3, parser.getRecordNumber());
627-
assertNull(record = parser.getRecord());
627+
assertNull(record = parser.nextRecord());
628628
assertEquals(8, parser.getLineNumber());
629629
assertEquals(3, parser.getRecordNumber());
630630
}
@@ -643,30 +643,30 @@ private void validateRecordNumbers(String lineSeparator) throws IOException {
643643
final CSVParser parser = new CSVParser("a" + lineSeparator + "b" + lineSeparator + "c", CSVFormat.DEFAULT.withLineSeparator(lineSeparator));
644644
CSVRecord record;
645645
assertEquals(0, parser.getRecordNumber());
646-
assertNotNull(record = parser.getRecord());
646+
assertNotNull(record = parser.nextRecord());
647647
assertEquals(1, record.getRecordNumber());
648648
assertEquals(1, parser.getRecordNumber());
649-
assertNotNull(record = parser.getRecord());
649+
assertNotNull(record = parser.nextRecord());
650650
assertEquals(2, record.getRecordNumber());
651651
assertEquals(2, parser.getRecordNumber());
652-
assertNotNull(record = parser.getRecord());
652+
assertNotNull(record = parser.nextRecord());
653653
assertEquals(3, record.getRecordNumber());
654654
assertEquals(3, parser.getRecordNumber());
655-
assertNull(record = parser.getRecord());
655+
assertNull(record = parser.nextRecord());
656656
assertEquals(3, parser.getRecordNumber());
657657
}
658658

659659
private void validateLineNumbers(String lineSeparator) throws IOException {
660660
final CSVParser parser = new CSVParser("a" + lineSeparator + "b" + lineSeparator + "c", CSVFormat.DEFAULT.withLineSeparator(lineSeparator));
661661
assertEquals(0, parser.getLineNumber());
662-
assertNotNull(parser.getRecord());
662+
assertNotNull(parser.nextRecord());
663663
assertEquals(1, parser.getLineNumber());
664-
assertNotNull(parser.getRecord());
664+
assertNotNull(parser.nextRecord());
665665
assertEquals(2, parser.getLineNumber());
666-
assertNotNull(parser.getRecord());
666+
assertNotNull(parser.nextRecord());
667667
// Still 2 because the last line is does not have EOL chars
668668
assertEquals(2, parser.getLineNumber());
669-
assertNull(parser.getRecord());
669+
assertNull(parser.nextRecord());
670670
// Still 2 because the last line is does not have EOL chars
671671
assertEquals(2, parser.getLineNumber());
672672
}

0 commit comments

Comments
 (0)