Skip to content

Upstream CJS require and typings for GuavaJS #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rzhw opened this issue Jan 29, 2020 · 0 comments · Fixed by #14
Closed

Upstream CJS require and typings for GuavaJS #5

rzhw opened this issue Jan 29, 2020 · 0 comments · Fixed by #14
Assignees

Comments

@rzhw
Copy link
Contributor

rzhw commented Jan 29, 2020

We're currently using a custom CommonJS wrapper and ambient typings for the guava-js bower package. The wrapper is a series of eval("[...]/node_modules/guava-js/[...].js") statements(!).

It'd be nice to either remove or replace this dependency, obsoleting this issue, or switch to an npm-published version of guava-js that can be loaded like any other regular Node.js module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant