Don't strip protocol from WordPress core update URLs

jeremyfelt · jeremyfelt · commit 95923436877c · 2015-10-10T12:44:50.000-07:00
A filter is added to make all URLs protocol relative, but our
handling of these in WordPress core for updates doesn't work. It's
possible this works in future versions of WordPress, but in my
testing while upgrading from 3.8.1 to 4.3.1, things stood still. :)
diff --git a/mu-plugins/jquery-filters.php b/mu-plugins/jquery-filters.php
@@ -113,5 +113,10 @@ function jquery_unfiltered_html_for_term_descriptions() {
 add_filter( 'theme_root_uri', 'strip_https', 10, 1 );
 add_filter( 'clean_url', 'strip_https', 11, 1 );
 function strip_https($url) {
+	// WordPress core updates need a protocol.
+	if ( 'downloads.wordpress.org' === parse_url( $url, PHP_URL_HOST ) ) {
+		return $url;
+	}
+
 	return preg_replace( '/^https?:/', '', $url );
 }
