Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: igorMSoares/js-css-animations
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: igorMSoares/js-css-animations
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: refactor
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 9 files changed
  • 1 contributor

Commits on Apr 7, 2023

  1. refactor: change setOverflowHidden() and removeOverflowHidden() from … 

    …resize-parent.js to animate.js
    @igorMSoares
    igorMSoares committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    445012a View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2023

  1. refactor: (WIP) create classes to handle different animation types

    @igorMSoares
    igorMSoares committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    cc0f587 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. refactor: dynamic import 'transitions' in updateCssProperties()

    @igorMSoares
    igorMSoares committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    7f3f91c View commit details
    Browse the repository at this point in the history

  2. refactor: remove unused code from animate.js 

    this code is now being accessed through the AnimationHandler classes
    @igorMSoares
    igorMSoares committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    f942342 View commit details
    Browse the repository at this point in the history

  3. fix: missing 'await' to wait for the Animation Handlers promises

    @igorMSoares
    igorMSoares committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    07f8617 View commit details
    Browse the repository at this point in the history

  4. refactor: change 'await' for '.then()' in some functions 

    in order not to propage the async through the functions call chain
    @igorMSoares
    igorMSoares committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    fe0eb9b View commit details
    Browse the repository at this point in the history

  5. fix: preset() must be async 

    in order to correctly get the custom duration and delay
set by the user
    @igorMSoares
    igorMSoares committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    b53a716 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. refactor: AnimationHandler's dependencies being imported by the builder 

    the dependencies were being imported inside the begin(), middle(), or end() methods
TODO: import dependencies right after page load to improve UX
    @igorMSoares
    igorMSoares committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    9083464 View commit details
    Browse the repository at this point in the history

  2. refactor: remove unused function in animate.js 

    function has moved to VisibilityAnimationHandler
    @igorMSoares
    igorMSoares committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    de1507d View commit details
    Browse the repository at this point in the history
Loading