Dead/redundent code and import removal.

Author: psh

app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java

@@ -1,19 +1,15 @@
 package fr.free.nrw.commons.nearby;
 
 import android.content.Intent;
-import android.content.SharedPreferences;
 import android.content.pm.PackageManager;
 import android.net.Uri;
 import android.os.Build;
 import android.os.Bundle;
-import android.preference.PreferenceManager;
 import android.support.annotation.NonNull;
 import android.support.design.widget.BottomSheetBehavior;
-import android.support.design.widget.FloatingActionButton;
 import android.support.v4.app.Fragment;
 import android.support.v4.app.FragmentTransaction;
 import android.support.v7.app.AlertDialog;
-import android.util.Log;
 import android.view.Menu;
 import android.view.MenuInflater;
 import android.view.MenuItem;
@@ -66,7 +62,6 @@ public class NearbyActivity extends NavigationBaseActivity implements LocationUp
 
     private LatLng curLatLang;
     private Bundle bundle;
-    private NearbyActivityMode viewMode;
     private Disposable placesDisposable;
     private boolean lockNearbyView; //Determines if the nearby places needs to be refreshed
     private BottomSheetBehavior bottomSheetBehavior; // Behavior for list bottom sheet
@@ -325,7 +320,7 @@ private void refreshView(boolean isHardRefresh) {
 
         progressBar.setVisibility(View.VISIBLE);
         placesDisposable = Observable.fromCallable(() -> nearbyController
-                .loadAttractionsFromLocation(curLatLang, this))
+                .loadAttractionsFromLocation(curLatLang))
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
                 .subscribe(this::populatePlaces);

app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivityMode.java

@@ -1,7 +1,5 @@
 package fr.free.nrw.commons.nearby;
 
-import android.support.annotation.NonNull;
-
 import com.pedrogomez.renderers.ListAdapteeCollection;
 import com.pedrogomez.renderers.RVRendererAdapter;
 import com.pedrogomez.renderers.RendererBuilder;
@@ -19,7 +17,7 @@ public RVRendererAdapter<Place> create(List<Place> placeList) {
         RendererBuilder<Place> builder = new RendererBuilder<Place>()
                 .bind(Place.class, new PlaceRenderer());
         ListAdapteeCollection<Place> collection = new ListAdapteeCollection<>(
-                placeList != null ? placeList : Collections.<Place>emptyList());
+                placeList != null ? placeList : Collections.emptyList());
         return new RVRendererAdapter<>(builder, collection);
     }
 }

app/src/main/java/fr/free/nrw/commons/nearby/NearbyAdapterFactory.java

@@ -37,7 +37,7 @@ private NearbyBaseMarker(Parcel in) {
                 .registerTypeAdapter(Uri.class, new UriDeserializer())
                 .create();
 
-        position((LatLng) in.readParcelable(LatLng.class.getClassLoader()));
+        position(in.readParcelable(LatLng.class.getClassLoader()));
         snippet(in.readString());
         String iconId = in.readString();
         Bitmap iconBitmap = in.readParcelable(Bitmap.class.getClassLoader());

app/src/main/java/fr/free/nrw/commons/nearby/NearbyBaseMarker.java

@@ -40,10 +40,9 @@ public NearbyController(NearbyPlaces nearbyPlaces,
     /**
      * Prepares Place list to make their distance information update later.
      * @param curLatLng current location for user
-     * @param context context
      * @return Place list without distance information
      */
-    public List<Place> loadAttractionsFromLocation(LatLng curLatLng, Context context) {
+    public List<Place> loadAttractionsFromLocation(LatLng curLatLng) {
         Timber.d("Loading attractions near %s", curLatLng);
         if (curLatLng == null) {
             return Collections.emptyList();

app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java

@@ -2,7 +2,6 @@
 
 import android.net.Uri;
 import android.os.Bundle;
-import android.support.v4.app.Fragment;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.RecyclerView;
 import android.view.LayoutInflater;
@@ -47,7 +46,7 @@ public View onCreateView(LayoutInflater inflater,
                              Bundle savedInstanceState) {
         Timber.d("NearbyListFragment created");
         View view = inflater.inflate(R.layout.fragment_nearby, container, false);
-        recyclerView = (RecyclerView) view.findViewById(R.id.listView);
+        recyclerView = view.findViewById(R.id.listView);
         recyclerView.setLayoutManager(new LinearLayoutManager(getContext()));
         adapterFactory = new NearbyAdapterFactory();
         return view;

app/src/main/java/fr/free/nrw/commons/nearby/NearbyInfoDialog.java

@@ -413,8 +413,8 @@ public void onClick(View view) {
 
         icon.setImageResource(place.getDescription().getIcon());
         description.setText(place.getDescription().getText());
-        title.setText(place.name.toString());
-        distance.setText(place.distance.toString());
+        title.setText(place.name);
+        distance.setText(place.distance);
     }
 
     private void openWebView(Uri link) {

app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java

@@ -2,19 +2,13 @@
 
 import android.content.Intent;
 import android.net.Uri;
-import android.os.CountDownTimer;
-import android.support.annotation.NonNull;
 import android.support.transition.TransitionManager;
-import android.support.v4.view.ViewCompat;
 import android.support.v7.widget.PopupMenu;
 import android.util.Log;
 import android.view.LayoutInflater;
 import android.view.MenuItem;
 import android.view.View;
 import android.view.ViewGroup;
-import android.view.ViewTreeObserver;
-import android.view.animation.Animation;
-import android.view.animation.AnimationUtils;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
 import android.widget.TextView;