Merge pull request commons-app#31 from brion/upload-fail-fix

Fix for crash report if network down when upload starts

Author: bvibber

commons/src/main/java/org/wikimedia/commons/UploadService.java

@@ -276,11 +276,11 @@ private void showFailedNotification(Contribution contribution) {
         contribution.save();
     }
 
-    private String findUniqueFilename(String fileName) {
+    private String findUniqueFilename(String fileName) throws IOException {
         return findUniqueFilename(fileName, 1);
     }
 
-    private String findUniqueFilename(String fileName, int sequenceNumber) {
+    private String findUniqueFilename(String fileName, int sequenceNumber) throws IOException  {
         String sequenceFileName;
         if (sequenceNumber == 1) {
             sequenceFileName = fileName;
@@ -304,18 +304,14 @@ private String findUniqueFilename(String fileName, int sequenceNumber) {
         }
     }
 
-    private boolean fileExistsWithName(String fileName) {
+    private boolean fileExistsWithName(String fileName) throws IOException {
         MWApi api = app.getApi();
         ApiResult result;
 
-        try {
-            result = api.action("query")
-                    .param("prop", "imageinfo")
-                    .param("titles", "File:" + fileName)
-                    .get();
-        } catch (IOException e) {
-            throw new RuntimeException(e);
-        }
+        result = api.action("query")
+                .param("prop", "imageinfo")
+                .param("titles", "File:" + fileName)
+                .get();
 
         ArrayList<ApiResult> nodes = result.getNodes("/api/query/pages/page/imageinfo");
         return nodes.size() > 0;