Skip to content

Commit ccd9e86

Browse files
committed
Remove unnecessary performNearbyOperations call on orientation changed.
1 parent b180824 commit ccd9e86

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,9 @@ public void onCreate(Bundle savedInstanceState) {
8383
onOrientationChanged = true; // Will be used in nearby fragment to determine significant update of map
8484

8585
//If nearby map was visible, call on Tab Selected to call all nearby operations
86-
if (savedInstanceState.getInt("viewPagerCurrentItem") == 1) {
86+
/*if (savedInstanceState.getInt("viewPagerCurrentItem") == 1) {
8787
((NearbyFragment)contributionsActivityPagerAdapter.getItem(1)).onTabSelected(onOrientationChanged);
88-
}
88+
}*/
8989
}
9090
}
9191

@@ -187,7 +187,6 @@ public void onPageSelected(int position) {
187187
updateMenuItem();
188188
// Do all permission and GPS related tasks on tab selected, not on create
189189
((NearbyFragment)contributionsActivityPagerAdapter.getItem(1)).onTabSelected(onOrientationChanged);
190-
191190
break;
192191
default:
193192
tabLayout.getTabAt(CONTRIBUTIONS_TAB_POSITION).select();

app/src/main/java/fr/free/nrw/commons/nearby/NearbyFragment.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -731,6 +731,7 @@ public void onResume() {
731731
}
732732

733733
public void onTabSelected(boolean onOrientationChanged) {
734+
Log.d("deneme***","onTabSelected");
734735
Timber.d("On nearby tab selected");
735736
this.onOrientationChanged = onOrientationChanged;
736737
performNearbyOperations();

0 commit comments

Comments
 (0)