Skip to content

Commit 1de2a24

Browse files
committed
Switch to more robust existing CSS escaping library
1 parent c678d91 commit 1de2a24

File tree

4 files changed

+13
-1
lines changed

4 files changed

+13
-1
lines changed

__tests__/escapeClassName.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import escapeClassName from '../src/util/escapeClassName'
2+
3+
test('invalid characters are escaped', () => {
4+
expect(escapeClassName('w:_$-1/2')).toEqual('w\\:_\\$-1\\/2')
5+
})

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
},
4444
"dependencies": {
4545
"commander": "^2.11.0",
46+
"css.escape": "^1.5.1",
4647
"fs-extra": "^4.0.2",
4748
"lodash": "^4.17.5",
4849
"perfectionist": "^2.4.0",

src/util/escapeClassName.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import escape from 'css.escape'
2+
13
export default function escapeClassName(className) {
2-
return className.replace(/([^A-Za-z0-9\-])/g, '\\$1')
4+
return escape(className)
35
}

yarn.lock

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1246,6 +1246,10 @@ cross-spawn@^5.0.1, cross-spawn@^5.1.0:
12461246
shebang-command "^1.2.0"
12471247
which "^1.2.9"
12481248

1249+
css.escape@^1.5.1:
1250+
version "1.5.1"
1251+
resolved "https://registry.yarnpkg.com/css.escape/-/css.escape-1.5.1.tgz#42e27d4fa04ae32f931a4b4d4191fa9cddee97cb"
1252+
12491253
cssom@0.3.x, "cssom@>= 0.3.2 < 0.4.0":
12501254
version "0.3.2"
12511255
resolved "https://registry.yarnpkg.com/cssom/-/cssom-0.3.2.tgz#b8036170c79f07a90ff2f16e22284027a243848b"

0 commit comments

Comments
 (0)